Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt plugin? #62

Closed
antelle opened this issue Nov 7, 2015 · 13 comments
Closed

Grunt plugin? #62

antelle opened this issue Nov 7, 2015 · 13 comments
Labels

Comments

@antelle
Copy link

antelle commented Nov 7, 2015

Great tool, thanks 👍
Are there any grunt plugins for this?

@stefanjudis
Copy link
Contributor

Nope, not yet. :)

Shouldn't take long to put one together... Feel free to go ahead if you need it quickly. :bowtie:

@antelle
Copy link
Author

antelle commented Nov 7, 2015

Yes, it's pretty easy. I've created it here, would you mind if I publish it to npm, or you will create one yourself later?
There's already a package grunt-electron-builder but it's totally different and it doesn't work for me at all.

@stefanjudis
Copy link
Contributor

Yes, it's pretty easy. I've created it here, would you mind if I publish it to npm, or you will create one yourself later?

No sure - go ahead. If you want to maintain it in future it sounds awesome to me.

There's already a package grunt-electron-builder but it's totally different and it doesn't work for me at all.

Maybe we want to quickly chat with the person? This looks like a horrible name collision here. And maybe we can work around that somehow without having kind of same samed packages on npm.

What would be you preferred name btw?

Thanks. :)

@antelle
Copy link
Author

antelle commented Nov 7, 2015

When I've found that grunt-electron-builder, I thought, it was for your project. That would be the best name for it. But I'm not sure about their plans. That project has 0 stars, 0 forks and was last updated 3 months ago, the author might have lost interest in it. I think yes, it's better to write them and ask to rename it.

@stefanjudis
Copy link
Contributor

When I've found that grunt-electron-builder, I thought, it was for your project. That would be the best name for it. But I'm not sure about their plans. That project has 0 stars, 0 forks and was last updated 3 months ago, the author might have lost interest in it. I think yes, it's better to write them and ask to rename it.

Jap, exactly... :) Let's check that first. Thanks for jumping in.

@stefanjudis
Copy link
Contributor

@antelle

any news here. I'm closing this one for now - but feel free to reopen. :)

@havenchyk
Copy link
Contributor

Hey @stefanjudis, JFI, since there is no response from the author of grunt-electron-builder, I've published grunt-electron-builder-wrapper

@stefanjudis
Copy link
Contributor

You waited 18h? That's not that long. ;)

Ja but sure - go ahead. If you want to add grunt-electron-builder-wrapper to the readme here please feel free to add via PR.

I can also have a look it at it if you wish - when it's up and running. :)

@havenchyk
Copy link
Contributor

Yep, but i haven't time to wait, so published it with another name. Thanks for you quick response and possible help, i really appreciate it.

@stefanjudis
Copy link
Contributor

Yep, but i haven't time to wait, so published it with another name.

Just to keep quality of npm packages high in the future. You're aware of the fact the you can install any git repo with npm?

Usually there is no need of publishing anything that is not ready yet ( e.g. your package is lacking a readme ) ;)

But anyways - sure. Wif you have troubles let me know. :)

stefanjudis added a commit that referenced this issue Dec 15, 2015
Added link to grunt plugin. #62
@antelle
Copy link
Author

antelle commented Apr 17, 2016

So now we have two unsupported grunt plugins? 😞
This issue is still open since Feb.19 https://github.com/havenchyk/grunt-electron-builder-wrapper/issues/6

@havenchyk
Copy link
Contributor

I'll take a look, @antelle thanks for pushing

@antelle
Copy link
Author

antelle commented Apr 17, 2016

@havenchyk thank you!
You should just remove .init() and replace callback with a promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants