Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of build in the application package.json #251

Closed
develar opened this issue Mar 17, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

Remove support of build in the application package.json #251

develar opened this issue Mar 17, 2016 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@develar
Copy link
Member

develar commented Mar 17, 2016

It is a source of confusion.

Why iconUrl, all electron-packager options should be specified in app package.json, but electron-builder specific options (extraResources) and windows-installer/appdmg options in the dev?

My proposal: use only build in the dev package.json. Also, it is important, because app paths should be relative to project dir (and in case of dev package.json it is clear and expected).

We can do this breaking change as part of 3.0 release (and remove deprecated <2.8 API).

@havenchyk
Copy link
Contributor

I'm agree, let's use the only place to make all the configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants