refactor: replace is-ci with ci-info to detect additional envs (like Azure) (#9117)

Author: talentlessguy

.changeset/many-toys-yell.md

@@ -0,0 +1,7 @@
+---
+"app-builder-lib": patch
+"builder-util": patch
+"electron-builder": patch
+---
+
+chore(deps): replace `is-ci` with `ci-info`

packages/app-builder-lib/package.json

@@ -59,6 +59,7 @@
     "builder-util": "workspace:*",
     "builder-util-runtime": "workspace:*",
     "chromium-pickle-js": "^0.2.0",
+    "ci-info": "^4.2.0",
     "config-file-ts": "0.2.8-rc1",
     "debug": "^4.3.4",
     "dotenv": "^16.4.5",
@@ -67,7 +68,6 @@
     "electron-publish": "workspace:*",
     "fs-extra": "^10.1.0",
     "hosted-git-info": "^4.1.0",
-    "is-ci": "^3.0.0",
     "isbinaryfile": "^5.0.0",
     "js-yaml": "^4.1.0",
     "json5": "^2.2.3",
@@ -104,7 +104,6 @@
     "@types/debug": "4.1.7",
     "@types/ejs": "3.1.0",
     "@types/hosted-git-info": "3.0.2",
-    "@types/is-ci": "3.0.0",
     "@types/js-yaml": "4.0.3",
     "@types/plist": "3.0.5",
     "@types/semver": "7.3.8",

packages/app-builder-lib/src/packager.ts

@@ -17,7 +17,7 @@ import {
 } from "builder-util"
 import { CancellationToken } from "builder-util-runtime"
 import { chmod, mkdirs, outputFile } from "fs-extra"
-import * as isCI from "is-ci"
+import { isCI } from "ci-info"
 import { Lazy } from "lazy-val"
 import { release as getOsRelease } from "os"
 import * as path from "path"

packages/app-builder-lib/src/publish/PublishManager.ts

@@ -28,7 +28,7 @@ import {
 } from "electron-publish"
 import { MultiProgress } from "electron-publish/out/multiProgress"
 import { writeFile } from "fs/promises"
-import * as isCi from "is-ci"
+import * as isCi from "ci-info"
 import * as path from "path"
 import { WriteStream as TtyWriteStream } from "tty"
 import * as url from "url"

packages/app-builder-lib/src/winPackager.ts

@@ -2,7 +2,7 @@ import { Arch, CopyFileTransformer, executeAppBuilder, FileTransformer, InvalidC
 import { Nullish } from "builder-util-runtime"
 import { createHash } from "crypto"
 import { readdir } from "fs/promises"
-import * as isCI from "is-ci"
+import { isCI } from "ci-info"
 import { Lazy } from "lazy-val"
 import * as path from "path"
 import { SignManager } from "./codeSign/signManager"

packages/builder-util/package.json

@@ -20,12 +20,12 @@
     "app-builder-bin": "5.0.0-alpha.12",
     "builder-util-runtime": "workspace:*",
     "chalk": "^4.1.2",
+    "ci-info": "^4.2.0",
     "cross-spawn": "^7.0.6",
     "debug": "^4.3.4",
     "fs-extra": "^10.1.0",
     "http-proxy-agent": "^7.0.0",
     "https-proxy-agent": "^7.0.0",
-    "is-ci": "^3.0.0",
     "js-yaml": "^4.1.0",
     "sanitize-filename": "^1.6.3",
     "source-map-support": "^0.5.19",
@@ -37,7 +37,6 @@
   "devDependencies": {
     "@types/cross-spawn": "6.0.6",
     "@types/fs-extra": "^9.0.11",
-    "@types/is-ci": "3.0.0",
     "@types/js-yaml": "4.0.3",
     "@types/source-map-support": "0.5.4",
     "@types/tiny-async-pool": "^1.0.5"

packages/builder-util/src/fs.ts

@@ -2,7 +2,7 @@ import { Nullish } from "builder-util-runtime"
 import { Stats } from "fs"
 import { copyFile as _nodeCopyFile } from "fs-extra"
 import { access, chmod, link, lstat, mkdir, readdir, readlink, stat, symlink, unlink, writeFile } from "fs/promises"
-import * as isCI from "is-ci"
+import { isCI } from "ci-info"
 import { platform } from "os"
 import * as path from "path"
 import { Mode } from "stat-mode"

packages/electron-builder/package.json

@@ -55,16 +55,15 @@
     "builder-util": "workspace:*",
     "builder-util-runtime": "workspace:*",
     "chalk": "^4.1.2",
+    "ci-info": "^4.2.0",
     "dmg-builder": "workspace:*",
     "fs-extra": "^10.1.0",
-    "is-ci": "^3.0.0",
     "lazy-val": "^1.0.5",
     "simple-update-notifier": "2.0.0",
     "yargs": "^17.6.2"
   },
   "devDependencies": {
     "@types/fs-extra": "9.0.13",
-    "@types/is-ci": "3.0.0",
     "@types/yargs": "^17.0.16"
   },
   "typings": "./out/index.d.ts",

packages/electron-builder/src/cli/cli.ts

@@ -6,7 +6,7 @@ import { nodeGypRebuild } from "app-builder-lib/out/util/yarn"
 import { ExecError, InvalidConfigurationError, log } from "builder-util"
 import * as chalk from "chalk"
 import { readJson } from "fs-extra"
-import * as isCi from "is-ci"
+import { isCI } from "ci-info"
 import * as path from "path"
 import { build, configureBuildCommand, createYargs } from "../builder"
 import { configurePublishCommand, publish } from "../publish"
@@ -64,7 +64,7 @@ function wrap(task: (args: any) => Promise<any>) {
 }
 
 async function checkIsOutdated() {
-  if (isCi || process.env.NO_UPDATE_NOTIFIER != null) {
+  if (isCI || process.env.NO_UPDATE_NOTIFIER != null) {
     return
   }