Switch mocha to jest #768
Merged
Switch mocha to jest #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akozhemiakin
force-pushed
the
jest
branch
4 times, most recently
from
f152b39
to
70949fb
Compare
|
Could you also change |
|
I fixed example.js but it seems that appveyor has some other reason to fail. I got very similar error one time and fixed it by deleting node_modules directory and reinstalling project. Do not know however how to fix appveyor. |
|
Actually @amilajack was do #613, we have the same problem on AppVeyor. :\ |
|
Maybe it expects \ instead of / ? Apveyor runs on windows after all. I'll check it. |
|
Hooray! I fixed it ) |
amilajack
requested changes
Feb 22, 2017
This commit replaces mocha with jest. Also this commit removes dependency on babel-plugin-webpack-loaders plugin because of the following reasons: 1. It seems that the author deprecated and abandoned this plugin and he suggests not to use it and to use mocks and native test utilities tools instead. 2. This plugin conflicts with webpack 2 and because of the reason one it is unlikely that it will ever support it. In order to remove dependency on the aforementioned plugin and keep using css modules in the same time the following trick is used: All components that need to be selected in the end-to-end test receive data-tid (TestID) and data-tclass (TestCLASS) properties. It is necessary because without running webpack we cannot use class names to select components because we do not know what class names css loader actually generates for us.
|
Done. I believe I remove all references to mocha. |
|
@akozhemiakin LGTM! |
amilajack
approved these changes
Feb 23, 2017
|
Nice. Now @amilajack you can fill another checkbox here #504 (: |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces mocha with jest. Also this commit removes dependency on
babel-plugin-webpack-loaders plugin because of the following reasons:
not to use it and to use mocks and native test utilities tools instead.
that it will ever support it.
In order to remove dependency on the aforementioned plugin and keep using css
modules in the same time the following trick is used: All components that need to
be selected in the end-to-end test receive data-tid (TestID) and data-tclass
(TestCLASS) properties. It is necessary because without running webpack we can't
use class names to select components because we do not know what class names
css loader actually generates for us.
P.S. I prepared upgrade to webpack 2 but it depends on this commit. So after this PR is closed I'll create pull request for webpack upgrade.