Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exploratory View] Add to Case #322

Closed
paulb-elastic opened this issue May 10, 2021 · 7 comments · Fixed by elastic/kibana#112463
Closed

[Exploratory View] Add to Case #322

paulb-elastic opened this issue May 10, 2021 · 7 comments · Fixed by elastic/kibana#112463

Comments

@paulb-elastic
Copy link

paulb-elastic commented May 10, 2021

As a user of the Observability cases capability
I want to be able to add a visualisation I've created in the exploratory view to an existing case
So that I can communicate observed insight visually in a way that users can then come back and manipulate themselves

ACs:

  • There is an "add to case" option in exploratory view
  • The case option shows all open cases
  • There is a search box to filter the list down based on case name or identifier
  • Adding a chart to a case is a snapshot in time. It will add the chart, as currently displayed, to the specified case.
    -- If a chart is using relative date ranges, these are converted to absolute date ranges
  • If an exploratory view chart is modified, and added to a case again, it does not replace what is already there but rather adds a new copy of the current state
  • There should be a link from cases back into exploratory view that loads the given chart in exploratory view(moved to a new issue [Exploratory View] Add link from case back to exploratory view #367)
@paulb-elastic paulb-elastic changed the title [Exploratory View] Integration with Cases [Exploratory View] Add to Case May 10, 2021
@katrin-freihofner
Copy link
Contributor

There is already a "add to new/existing case" workflow for alerts, we might be able to reuse.

@paulb-elastic
Copy link
Author

@liciavale (cc @drewpost), we might need some help working out the best design for this (see also Katrin's comment above).

@shahzad31
Copy link

@drewpost Observability cases are still behind feature flag, does that effect this ticket?

@drewpost
Copy link

@shahzad31 My understanding is that they will be out from there in 7.16. @cyrille-leclerc can you confirm if that is still on track?

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Sep 16, 2021

This is the workflow we currently have in place in the alerts view:

Creating a new case

Screenshot 2021-09-16 at 13 54 05

Adding alert to an existing case

Screenshot 2021-09-16 at 13 53 54

You can test the interaction on edge.

@lucasfcosta
Copy link

I've tested this PR in two ways: following Dominique's comments on the PR, and following Paul's instructions in this issue.

Test Results (As per Paul's description)

As per Paul's description, here's how I've tested this issue:

  1. I created five cases:
    1. two open cases from different reporters each
    2. one in-progress case
    3. one closed case
    4. one reopened case

Screenshot 2021-11-01 at 16 57 57

  1. I created a new visualisation using the Exploratory View and added it to an open case.
  2. I could correctly filter cases by their statuses, names, reporters, and tags.
  3. The toast informing that the visualisation was added successfully is displayed as expected, and its link works.
  4. I went into the case and was able to find the visualisation in there, as expected.

saving-to-case-and-filters

  1. When editing a visualisation and removing a metric from it, the visualisation within the case did not change, as expected.

editing-preserves-case

  1. When adding a visualisation with relative dates, those were not converted to absolute dates. As you can see in the GIF below, every time I refreshed the case, I was able to see more recent measurements because the end date was set as "now".
    Additionally, the start_date also changes so that it's always X minutes ago, not at an absolute time.
    Clicking "open visualisation" also displays the relative time as the chart's time range.
    relative-not-working
    The related issue for this is at: [Uptime] Visualisations remain with relative dates when added to cases kibana#117008

  2. This issues lists as an acceptance criteria:

    The case option shows all open cases
    However, the case options show all cases, including closed ones. It's also possible to add a visualisation to a closed case. In my opinion, that seems okay from a functional perspective, but given it deviates from the original spec I've added an issue here: [Uptime] Closed cases showing by default when adding Exploratory View visualisations to case kibana#117006. Please feel free to close if the spec has changed or if we're actually okay with it as is.

adding-to-closed-case

Test Results (as per Dominique's comments on the PR)

Test Case 1 - "Add To Case" modal button should work after changing report type

  1. Clicked "Add To Case" > Closed the "Add To Case" modal
  2. Changed report type
  3. Clicked "Add to Case" button again, and it works as expected.

readd-change-type-works

Test Case 2 - "Add To Case" modal button should work after changing report type

  1. Using Synthetics Monitoring -> KPI Over Time as an example, set a value for monitor name
  2. Click Add To Case Button
  3. Exit Add To Case modal
  4. Remove monitor name
  5. Add monitor name again
  6. Notice that the modal does not pop up again without clicking the button.

changing-name-no-popup


Questions

  1. When selecting tags, as the popup changed dimensions, the position of the select element ended up being a bit weird. Is that an issue I should report on Kibana or in our component library?
  2. Can someone confirm the "Expected Behaviour" I described in [Uptime] Closed cases showing by default when adding Exploratory View visualisations to case kibana#117006 is really the desired one? (CC @drewpost and @paulb-elastic).

@shahzad31
Copy link

@lucasfcosta

Thanks for the detailed testing
Regarding
When selecting tags, as the popup changed dimensions, the position of the select element ended up being a bit weird. Is that an issue I should report on Kibana or in our component library?

Please open an issue in the kibana repo, we will redirect it to the team which owns this component, i think it's woned by RAC initiative.

And thanks for opening the other issue regarding elastic/kibana#117006

we can probably discuss this in refinement as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants