[ML] Don't lose mean offset in expanding window when persisting #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
force-pushed
the
bug/persist-and-restore-mean-offset
branch
from
e05cbd0 to
1770b6f
Compare
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
May 25, 2018
…tic#99) We were not persisting and restoring the mean offset time of the values added to the expanding window w.r.t. the start of the data buckets. This was therefore getting reset to 0 on a persist restore cycle. This will introduce a small error when initialising periodic components after a persist and restore.
tveasey
added a commit
that referenced
this pull request
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not persisting and restoring the mean offset time of the values added to the expanding window w.r.t. the start of the data buckets. This was therefore getting reset to 0 on a persist restore cycle.
This will introduce a small error when initialising periodic components after a persist and restore and would affect results in this context.
Release note: Fixes persist and restore, which were missing some of the trend model state.