Skip to content

[ML] Improve robustness to very low variance data #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Oct 4, 2018

This fixes a couple of potential issues:

  1. If the variance of the data was zero it could cause a nan in the decomposition component errors. The most serious side effect is that it would cause us to fail to restore state on Windows.
  2. The check for low coefficient of variation data in the periodic component test should always use the raw bucket values to calculate the mean.

This turned up in a unit test failure back porting #198 to 6.5. As such this is effectively a forward port of the fix I made directly to that commit. I've marked this as a non-issue as this is related to unreleased code.

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit b73df65 into elastic:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants