-
Notifications
You must be signed in to change notification settings - Fork 65
[ML] Activate model metadata output #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 14, 2020
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Aug 14, 2020
…_metadata relates to elastic/ml-cpp#1456
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 14, 2020
…_metadata relates to elastic/ml-cpp#1456
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Aug 14, 2020
…_metadata (#61158) relates to elastic/ml-cpp#1456
jenkins retest this please |
benwtrent
added a commit
that referenced
this pull request
Aug 24, 2020
Activate the output of the model metadata and the corresponding unit tests for total feature importance. The implementation itself was introduced in #1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs. Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Sep 1, 2020
Activate the output of the model metadata and the corresponding unit tests for total feature importance. The implementation itself was introduced in elastic#1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate the output of the model metadata and the corresponding unit tests for total feature importance.
The implementation itself was introduced in #1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs.