Skip to content

[ML] Activate model metadata output #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

valeriy42
Copy link
Contributor

Activate the output of the model metadata and the corresponding unit tests for total feature importance.

The implementation itself was introduced in #1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member

jenkins retest this please

@benwtrent benwtrent merged commit e25d10f into elastic:master Aug 14, 2020
benwtrent added a commit that referenced this pull request Aug 24, 2020
Activate the output of the model metadata and the corresponding unit tests for total feature importance.

The implementation itself was introduced in #1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs.

Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
valeriy42 added a commit to valeriy42/ml-cpp that referenced this pull request Sep 1, 2020
Activate the output of the model metadata and the corresponding unit tests for total feature importance.

The implementation itself was introduced in elastic#1387 however, I need to fix the documentation, it was originally attributed to v7.10. Hence, I mark this PR as enhancement to rectify the docs.
@valeriy42 valeriy42 deleted the total-shap-activate branch March 1, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants