[ML] Fix warnings due to -Wsuggest-override compiler flag (#2119)

Adding the `override` keyword where necessary to subdue compiler
warnings.

Author: edsavage

include/api/CAnomalyJobConfigReader.h

@@ -65,7 +65,7 @@ class API_EXPORT CAnomalyJobConfigReader {
     public:
         explicit CParseError(const std::string& what)
             : std::runtime_error{what} {}
-        virtual ~CParseError() noexcept = default;
+        ~CParseError() noexcept override = default;
     };
 
 public:

include/api/CHierarchicalResultsWriter.h

@@ -154,7 +154,7 @@ class API_EXPORT CHierarchicalResultsWriter : public model::CHierarchicalResults
                                const TPivotWriterFunc& pivotsWriterFunc);
 
     //! Write \p node.
-    virtual void visit(const model::CHierarchicalResults& results, const TNode& node, bool pivot);
+    void visit(const model::CHierarchicalResults& results, const TNode& node, bool pivot) override;
 
 private:
     //! Write out a population person result if \p node is a

include/api/CInferenceModelDefinition.h

@@ -164,7 +164,7 @@ class API_EXPORT CTrainedModel : public CSerializableToJsonStream {
     using TSizeInfoUPtr = std::unique_ptr<CSizeInfo>;
 
 public:
-    virtual ~CTrainedModel() override = default;
+    ~CTrainedModel() override = default;
     void addToJsonStream(TGenericLineWriter& writer) const override;
     //! Names of the features used by the model.
     virtual const TStringVec& featureNames() const;

include/api/CPersistenceManager.h

@@ -150,8 +150,8 @@ class API_EXPORT CPersistenceManager : private core::CNonCopyable {
 
     protected:
         //! Inherited virtual interface
-        virtual void run();
-        virtual void shutdown();
+        void run() override;
+        void shutdown() override;
 
     private:
         //! Reference to the owning background persister

include/core/CBlockingCallCancellingTimer.h

@@ -56,11 +56,11 @@ class CORE_EXPORT CBlockingCallCancellingTimer : public CBlockingCallCancellerTh
     //! Derived classes must implement this such that it waits for the
     //! appropriate indication that the blocking call should be cancelled,
     //! or until it is told to stop waiting by stopWaitForCondition().
-    virtual void waitForCondition();
+    void waitForCondition() override;
 
     //! Derived classes must implement this such that when called it causes
     //! the waitForCondition() method to return false immediately.
-    virtual void stopWaitForCondition();
+    void stopWaitForCondition() override;
 
 private:
     using TMutexUniqueLock = std::unique_lock<std::mutex>;

include/core/CCompressOStream.h

@@ -39,7 +39,7 @@ class CORE_EXPORT CCompressOStream : public std::ostream {
     CCompressOStream(CStateCompressor::CChunkFilter& filter);
 
     //! Destructor will close the stream
-    virtual ~CCompressOStream();
+    ~CCompressOStream() override;
 
     //! Close the stream
     void close();
@@ -53,8 +53,8 @@ class CORE_EXPORT CCompressOStream : public std::ostream {
 
     protected:
         //! Implementation of inherited interface
-        virtual void run();
-        virtual void shutdown();
+        void run() override;
+        void shutdown() override;
 
     public:
         //! Reference to the owning stream

include/core/CDualThreadStreamBuf.h

@@ -88,41 +88,41 @@ class CORE_EXPORT CDualThreadStreamBuf : public std::streambuf {
     //! Get an estimate of the number of characters still to read after an
     //! underflow.  In the case of this class we return the amount of data
     //! in the intermediate buffer.
-    virtual std::streamsize showmanyc();
+    std::streamsize showmanyc() override;
 
     //! Switch the buffers immediately.  Effectively this flushes data
     //! through with lower latency but also less efficiently.
-    virtual int sync();
+    int sync() override;
 
     //! Get up to n characters from the read buffer and store them in the
     //! array pointed to by s.
-    virtual std::streamsize xsgetn(char* s, std::streamsize n);
+    std::streamsize xsgetn(char* s, std::streamsize n) override;
 
     //! Try to obtain more data for the write buffer.  This is done by
     //! swapping it with the intermediate buffer.  This may block if no data
     //! is available to read in the intermediate buffer.
-    virtual int underflow();
+    int underflow() override;
 
     //! Put character back in the case of backup underflow.
-    virtual int pbackfail(int c = traits_type::eof());
+    int pbackfail(int c = traits_type::eof()) override;
 
     //! Write up to n characters from the array pointed to by s into the
     //! write buffer.
-    virtual std::streamsize xsputn(const char* s, std::streamsize n);
+    std::streamsize xsputn(const char* s, std::streamsize n) override;
 
     //! Try to obtain more space in the write buffer.  This is done by
     //! swapping it with the intermediate buffer.  This may block if no data
     //! is available to read in the intermediate buffer.
-    virtual int overflow(int c = traits_type::eof());
+    int overflow(int c = traits_type::eof()) override;
 
     //! In a random access stream this would seek to the specified position.
     //! This class does not support such seeking, but implements this method
     //! allowing a zero byte seek in order to allow tellg() and tellp() to
     //! work on the connected stream.
-    virtual std::streampos
-    seekoff(std::streamoff off,
-            std::ios_base::seekdir way,
-            std::ios_base::openmode which = std::ios_base::in | std::ios_base::out);
+    std::streampos seekoff(std::streamoff off,
+                           std::ios_base::seekdir way,
+                           std::ios_base::openmode which = std::ios_base::in |
+                                                           std::ios_base::out) override;
 
 private:
     //! Swap the intermediate buffer with the write buffer.  Will block if

include/core/CJsonStatePersistInserter.h

@@ -45,10 +45,10 @@ class CORE_EXPORT CJsonStatePersistInserter : public CStatePersistInserter {
     CJsonStatePersistInserter(std::ostream& outputStream);
 
     //! Destructor flushes
-    virtual ~CJsonStatePersistInserter();
+    ~CJsonStatePersistInserter() override;
 
     //! Store a name/value
-    virtual void insertValue(const std::string& name, const std::string& value);
+    void insertValue(const std::string& name, const std::string& value) override;
 
     //! Write as an integer avoiding the string conversion
     //! overloads
@@ -62,10 +62,10 @@ class CORE_EXPORT CJsonStatePersistInserter : public CStatePersistInserter {
 
 protected:
     //! Start a new level with the given name
-    virtual void newLevel(const std::string& name);
+    void newLevel(const std::string& name) override;
 
     //! End the current level
-    virtual void endLevel();
+    void endLevel() override;
 
 private:
     //! JSON writer ostream wrapper

include/core/CRapidJsonConcurrentLineWriter.h

@@ -51,7 +51,7 @@ class CORE_EXPORT CRapidJsonConcurrentLineWriter
     //! \p outStream reference to an wrapped output stream
     CRapidJsonConcurrentLineWriter(CJsonOutputStreamWrapper& outStream);
 
-    ~CRapidJsonConcurrentLineWriter();
+    ~CRapidJsonConcurrentLineWriter() override;
 
     //! Flush buffers, including the output stream.
     //! Note: flush still happens asynchronous
@@ -72,7 +72,7 @@ class CORE_EXPORT CRapidJsonConcurrentLineWriter
     //! are not virtual and we need to avoid "slicing" the writer to ensure that
     //! that the correct StartObject/EndObject functions are called when this is
     //! passed to \p doc Accept.
-    void write(const rapidjson::Value& doc) { doc.Accept(*this); }
+    void write(const rapidjson::Value& doc) override { doc.Accept(*this); }
 
 private:
     //! The stream object

include/core/CRapidJsonLineWriter.h

@@ -64,7 +64,7 @@ class CRapidJsonLineWriter
     //! are not virtual and we need to avoid "slicing" the writer to ensure that
     //! that the correct StartObject/EndObject functions are called when this is
     //! passed to \p doc Accept.
-    void write(const rapidjson::Value& doc) { doc.Accept(*this); }
+    void write(const rapidjson::Value& doc) override { doc.Accept(*this); }
 
 private:
     size_t m_ObjectCount = 0;