do not return a temporary

Hendrik Muhs · Hendrik Muhs · commit 98ab90b1e187 · 2018-05-14T11:03:56.000+02:00
diff --git a/include/model/CForecastModelPersist.h b/include/model/CForecastModelPersist.h
@@ -52,7 +52,7 @@ class MODEL_EXPORT CForecastModelPersist final {
                       const std::string& byFieldValue);
 
         //! close the outputStream
-        const std::string& finalizePersistAndGetFile();
+        std::string finalizePersistAndGetFile();
 
     private:
         static void persistOneModel(core::CStatePersistInserter& inserter,
diff --git a/lib/model/CForecastModelPersist.cc b/lib/model/CForecastModelPersist.cc
@@ -60,9 +60,10 @@ void CForecastModelPersist::CPersist::persistOneModel(core::CStatePersistInserte
                                                       boost::cref(*model), _1));
 }
 
-const std::string& CForecastModelPersist::CPersist::finalizePersistAndGetFile() {
+std::string CForecastModelPersist::CPersist::finalizePersistAndGetFile() {
     m_OutStream << "]";
     m_OutStream.close();
+
     return m_FileName.string();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,9 +60,10 @@ void CForecastModelPersist::CPersist::persistOneModel(core::CStatePersistInserte`
`60`	`60`	`boost::cref(*model), _1));`
`61`	`61`	`}`
`62`	`62`
`63`		`-const std::string& CForecastModelPersist::CPersist::finalizePersistAndGetFile() {`
	`63`	`+std::string CForecastModelPersist::CPersist::finalizePersistAndGetFile() {`
`64`	`64`	`m_OutStream << "]";`
`65`	`65`	`m_OutStream.close();`
	`66`	`+`
`66`	`67`	`return m_FileName.string();`
`67`	`68`	`}`
`68`	`69`