Skip to content

Commit 3eb4114

Browse files
authored
[ML] Build PyTorch without Breakpad (#2255)
Breakpad causes the libtorch_cpu.so library to have an executable stack, which is undesirable. Fixes elastic/elasticsearch#85691
1 parent f9cd37e commit 3eb4114

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

build-setup/linux.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,8 @@ export USE_MKLDNN=ON
325325
export USE_QNNPACK=OFF
326326
export USE_PYTORCH_QNNPACK=OFF
327327
[ $(uname -m) = x86_64 ] && export USE_XNNPACK=OFF
328-
[ $(uname -m) != x86_64 ] && export USE_BREAKPAD=OFF
328+
# Breakpad is undesirable as it causes libtorch_cpu to have an executable stack
329+
export USE_BREAKPAD=OFF
329330
export PYTORCH_BUILD_VERSION=1.11.0
330331
export PYTORCH_BUILD_NUMBER=1
331332
/usr/local/gcc103/bin/python3.7 setup.py install

dev-tools/docker/build_linux_build_image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ sleep 5
3434
HOST=docker.elastic.co
3535
ACCOUNT=ml-dev
3636
REPOSITORY=ml-linux-build
37-
VERSION=21
37+
VERSION=22
3838

3939
set -e
4040

dev-tools/docker/linux_builder/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111

1212
# Increment the version here when a new tools/3rd party components image is built
13-
FROM docker.elastic.co/ml-dev/ml-linux-build:21
13+
FROM docker.elastic.co/ml-dev/ml-linux-build:22
1414

1515
MAINTAINER David Roberts <dave.roberts@elastic.co>
1616

dev-tools/docker/linux_image/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ RUN \
148148
export USE_QNNPACK=OFF && \
149149
export USE_PYTORCH_QNNPACK=OFF && \
150150
export USE_XNNPACK=OFF && \
151+
export USE_BREAKPAD=OFF && \
151152
export PYTORCH_BUILD_VERSION=1.11.0 && \
152153
export PYTORCH_BUILD_NUMBER=1 && \
153154
/usr/local/bin/python3.7 setup.py install && \

dev-tools/docker/linux_tester/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111

1212
# Increment the version here when a new tools/3rd party components image is built
13-
FROM docker.elastic.co/ml-dev/ml-linux-build:21
13+
FROM docker.elastic.co/ml-dev/ml-linux-build:22
1414

1515
MAINTAINER David Roberts <dave.roberts@elastic.co>
1616

0 commit comments

Comments
 (0)