Skip to content

Conversation

@nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Nov 12, 2020

Summary

fix #83339

Fix very tall charts from rendering off the page. Regression from #80744

Screen Recording 2020-11-12 at 02 12 32 PM

@nickofthyme nickofthyme added the Feature:Vislib Vislib chart implementation label Nov 12, 2020
@nickofthyme nickofthyme requested a review from a team as a code owner November 12, 2020 20:19
@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 12, 2020
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out locally - looks good!

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @nickofthyme for fixing this! I tested it locally in Safari and works fine! ❤️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 702.0KB 702.6KB +584.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 3ba7758 into elastic:master Nov 16, 2020
@nickofthyme nickofthyme deleted the fix-tall-vislib-chart branch November 16, 2020 14:26
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 16, 2020
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana:
  fix tall vislib charts in visualize (elastic#83340)
  [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957)
  [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401)
  fix logstash central pipeline management test  (elastic#83281)
  [Search] Send to background UI (elastic#81793)
  Migrate `/translations` route to core (elastic#83280)
  [APM] Ensure APM jest script can run (elastic#83398)
  [Uptime] Monitor status alert use url as instance (elastic#81736)
  [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259)
  TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964)
  [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139)
  Skips Vega test
  skip flaky suite (elastic#79967)
  [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020)
  Added ability to fire actions when an alert instance is resolved (elastic#82799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Vislib Vislib chart implementation release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tall vislib chart renders outside of window

4 participants