Make sure getOpsMetrics$ only replays lastest value #77673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
3 tasks
pgayvallet
approved these changes
Sep 16, 2020
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 16, 2020
pgayvallet
pushed a commit
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We switched to using a ReplaySubject for the
getOpsMetrics$API in #76730 but did not specify thebufferparameter causing all values to be replayed each time this API was called. This adds a buffer of 1 so that only the last value is replayed.Checklist
Delete any items that are not applicable to this PR.