Skip to content

Conversation

@yctercero
Copy link
Contributor

Backports the following commits to 7.x:

…tic#76544)

## Summary

Mistmatch caught between the io-ts type and the corresponding typescript enum. Currently, io-ts does not have support for enums - as a workaround I had made a matching typescript enum type. Tests were added to try to ensure the two stayed in sync, but didn't do a straight up comparison of the two.

Updated the tests to now error if the keys do not match.
@yctercero yctercero added the backport This PR is a backport of another PR label Sep 3, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lists 164.1KB -187.0B 164.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit cc621ef into elastic:7.x Sep 3, 2020
@yctercero yctercero deleted the backport/7.x/pr-76544 branch October 14, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants