Adding api test for transaction_groups /breakdown and /avg_duration_by_browser #72623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
cauemarcondes
commented
Jul 21, 2020
cauemarcondes
commented
Jul 21, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
sorenlouv
requested changes
Jul 21, 2020
Member
sorenlouv
left a comment
sorenlouv
left a comment
There was a problem hiding this comment.
You most likely shouldn't remove transactionType and tranactionName
Contributor
Author
I put the |
sorenlouv
reviewed
Jul 21, 2020
x-pack/test/apm_api_integration/basic/tests/transaction_groups/avg_duration_by_browser.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/basic/tests/transaction_groups/breakdown.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 21, 2020
x-pack/test/apm_api_integration/basic/tests/transaction_groups/breakdown.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 21, 2020
x-pack/test/apm_api_integration/basic/tests/transaction_groups/breakdown.ts
Show resolved
Hide resolved
sorenlouv
approved these changes
Jul 21, 2020
sorenlouv
reviewed
Jul 22, 2020
x-pack/test/apm_api_integration/basic/tests/transaction_groups/breakdown.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Jul 22, 2020
x-pack/test/apm_api_integration/basic/tests/transaction_groups/breakdown.ts
Outdated
Show resolved
Hide resolved
Member
|
@elasticmachine merge upstream |
…arcondes/kibana into apm-transaction-breakdown-api-test
sorenlouv
approved these changes
Jul 22, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Jul 22, 2020
…y_browser (#72623) * adding api test for transaction_groups /breakdown and /avg_duration_by_browser * adding filter by transaction name * adding filter by transaction name * addressing pr comments * fixing TS issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
pushed a commit
that referenced
this pull request
Jul 22, 2020
…y_browser (#72623) * adding api test for transaction_groups /breakdown and /avg_duration_by_browser * adding filter by transaction name * adding filter by transaction name * addressing pr comments * fixing TS issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
* master: (34 commits) Adds Role Based Access-Control to the Alerting & Action plugins based on Kibana Feature Controls (elastic#67157) [Monitoring] Revert direct shipping code (elastic#72505) Use server basepath when creating reporting jobs (elastic#72722) Adding api test for transaction_groups /breakdown and /avg_duration_by_browser (elastic#72623) [Task Manager] Addresses flaky test introduced by buffered store (elastic#72815) [Observability] filter "hasData" api by processor event (elastic#72810) do not pass title as part of tsvb request (elastic#72619) [Lens] Legend config (elastic#70619) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) ...
cauemarcondes
added a commit
that referenced
this pull request
Jul 22, 2020
…y_browser (#72623) (#72839) * adding api test for transaction_groups /breakdown and /avg_duration_by_browser * adding filter by transaction name * adding filter by transaction name * addressing pr comments * fixing TS issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cauemarcondes
added a commit
that referenced
this pull request
Jul 22, 2020
…y_browser (#72623) (#72840) * adding api test for transaction_groups /breakdown and /avg_duration_by_browser * adding filter by transaction name * adding filter by transaction name * addressing pr comments * fixing TS issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.