Skip to content

[Maps] Improve language for mvt card #71947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Maps] Improve language for mvt card #71947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f1aa84
improve language
thomasneirynck Jul 15, 2020
acc640e
fix unit test
thomasneirynck Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...t_single_layer_vector_source/__snapshots__/mvt_single_layer_source_settings.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ublic/classes/sources/mvt_single_layer_vector_source/mvt_single_layer_source_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export class MVTSingleLayerSourceSettings extends Component<Props, State> {
label={i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSourceEditor.layerNameMessage',
{
defaultMessage: 'Tile layer',
defaultMessage: 'Source layer',
Copy link
Contributor Author

@thomasneirynck thomasneirynck Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source layer matches the source-layer naming in the TileJson-spec and it's corresponding use in the mapbox-gl spec.

}
)}
>
Expand Down
2 changes: 1 addition & 1 deletion ...ic/classes/sources/mvt_single_layer_vector_source/mvt_single_layer_vector_source.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('getImmutableSourceProperties', () => {
const source = new MVTSingleLayerVectorSource(descriptor);
const properties = await source.getImmutableProperties();
expect(properties).toEqual([
{ label: 'Data source', value: '.pbf vector tiles' },
{ label: 'Data source', value: 'Vector tiles' },
{ label: 'Url', value: 'https://example.com/{x}/{y}/{z}.pbf' },
]);
});
Expand Down
2 changes: 1 addition & 1 deletion .../public/classes/sources/mvt_single_layer_vector_source/mvt_single_layer_vector_source.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { ITooltipProperty, TooltipProperty } from '../../tooltips/tooltip_proper
export const sourceTitle = i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSource.sourceTitle',
{
defaultMessage: '.pbf vector tiles',
defaultMessage: 'Vector tiles',
Copy link
Contributor

@kmartastic kmartastic Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this text.

}
);

Expand Down