Skip to content

Fix flaky test Kibana embedded in iframe #71813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix flaky test Kibana embedded in iframe #71813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions x-pack/test/functional_embedded/tests/iframe_embedded.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const browser = getService('browser');
const config = getService('config');
const testSubjects = getService('testSubjects');
const retry = getService('retry');

// Flaky: https://github.com/elastic/kibana/issues/70928
describe.skip('in iframe', () => {
describe('in iframe', () => {
it('should open Kibana for logged-in user', async () => {
const isChromeHiddenBefore = await PageObjects.common.isChromeHidden();
expect(isChromeHiddenBefore).to.be(true);
Expand All @@ -36,8 +36,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const iframe = await testSubjects.find('iframe_embedded');
await browser.switchToFrame(iframe);

const isChromeHidden = await PageObjects.common.isChromeHidden();
expect(isChromeHidden).to.be(false);
await retry.waitFor('page rendered for a logged-in user', async () => {
return await PageObjects.common.isChromeVisible();
});
});
});
}