Skip to content

[Security Solution]Fix in-app links and popup window text #71403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2020
Merged

[Security Solution]Fix in-app links and popup window text #71403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0a8efb4
updates in-app links
Jul 13, 2020
4cb9f79
updates links from prebuilt ML jobs
Jul 13, 2020
e9d8b3f
updates kibana help window text and link
Jul 13, 2020
aaa7e2a
removes problematic terminolgy from prebuilt job descriptions
Jul 13, 2020
eb86e96
Revert "removes problematic terminolgy from prebuilt job descriptions"
Jul 13, 2020
9234481
Revert "updates links from prebuilt ML jobs"
Jul 13, 2020
6b76da6
recommits the link correction after revert
Jul 13, 2020
be91bf3
changes help window app name to Security
Jul 15, 2020
e225ba1
Merge branch 'master' into in-app-links-and-terminology
Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/public/doc_links/doc_links_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ export class DocLinksService {
},
kibana: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index.html`,
siem: {
guide: `${ELASTIC_WEBSITE_URL}guide/en/siem/guide/${DOC_LINK_VERSION}/index.html`,
gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/siem/guide/${DOC_LINK_VERSION}/install-siem.html`,
guide: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`,
gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/install-siem.html`,
},
query: {
luceneQuerySyntax: `${ELASTICSEARCH_DOCS}query-dsl-query-string-query.html#query-string-syntax`,
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/cases/pages/saved_object_no_permissions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const CaseSavedObjectNoPermissions = React.memo(() => {
<EmptyPage
actionPrimaryIcon="documents"
actionPrimaryLabel={i18n.GO_TO_DOCUMENTATION}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/siem/guide/${docLinks.DOC_LINK_VERSION}s`}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${docLinks.DOC_LINK_VERSION}s`}
actionPrimaryTarget="_blank"
message={i18n.SAVED_OBJECT_NO_PERMISSIONS_MSG}
data-test-subj="no_saved_objects_permissions"
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/common/components/help_menu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ export const HelpMenu = React.memo(() => {
useEffect(() => {
chrome.setHelpExtension({
appName: i18n.translate('xpack.securitySolution.chrome.help.appName', {
defaultMessage: 'SIEM',
defaultMessage: 'Security',
}),
links: [
{
content: i18n.translate('xpack.securitySolution.chrome.helpMenu.documentation', {
defaultMessage: 'SIEM documentation',
defaultMessage: 'Security documentation',
}),
href: docLinks.links.siem.guide,
iconType: 'documents',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export const MlPopover = React.memo(() => {
values={{
mlDocs: (
<a
href={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/siem/guide/${docLinks.DOC_LINK_VERSION}/machine-learning.html`}
href={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${docLinks.DOC_LINK_VERSION}/machine-learning.html`}
rel="noopener noreferrer"
target="_blank"
>
Expand Down
2 changes: 1 addition & 1 deletion ...ecurity_solution/public/detections/components/rules/pre_packaged_rules/update_callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const UpdatePrePackagedRulesCallOutComponent: React.FC<UpdatePrePackagedRulesCal
{prepackagedRulesOrTimelines?.callOutMessage}
<br />
<EuiLink
href={`${services.docLinks.ELASTIC_WEBSITE_URL}guide/en/siem/guide/${services.docLinks.DOC_LINK_VERSION}/prebuilt-rules-changelog.html`}
href={`${services.docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${services.docLinks.DOC_LINK_VERSION}/prebuilt-rules-changelog.html`}
target="_blank"
>
{i18n.RELEASE_NOTES_HELP}
Expand Down
2 changes: 1 addition & 1 deletion ...ty_solution/public/detections/pages/detection_engine/detection_engine_no_signal_index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const DetectionEngineNoIndex = React.memo(() => {
<EmptyPage
actionPrimaryIcon="documents"
actionPrimaryLabel={i18n.GO_TO_DOCUMENTATION}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/siem/guide/${docLinks.DOC_LINK_VERSION}/detection-engine-overview.html#detections-permissions`}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${docLinks.DOC_LINK_VERSION}/detection-engine-overview.html#detections-permissions`}
actionPrimaryTarget="_blank"
message={i18n.NO_INDEX_MSG_BODY}
data-test-subj="no_index"
Expand Down
2 changes: 1 addition & 1 deletion ...lution/public/detections/pages/detection_engine/detection_engine_user_unauthenticated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const DetectionEngineUserUnauthenticated = React.memo(() => {
<EmptyPage
actionPrimaryIcon="documents"
actionPrimaryLabel={i18n.GO_TO_DOCUMENTATION}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/security/guide/${docLinks.DOC_LINK_VERSION}/detection-engine-overview.html#detections-permissions`}
actionPrimaryUrl={`${docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${docLinks.DOC_LINK_VERSION}/detection-engine-overview.html#detections-permissions`}
actionPrimaryTarget="_blank"
message={i18n.USER_UNAUTHENTICATED_MSG_BODY}
data-test-subj="no_index"
Expand Down
2 changes: 1 addition & 1 deletion ...y_solution/public/network/components/embeddables/__snapshots__/embedded_map.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export const EmbeddedMapComponent = ({
<EmbeddableHeader title={i18n.EMBEDDABLE_HEADER_TITLE}>
<EuiText size="xs">
<EuiLink
href={`${services.docLinks.ELASTIC_WEBSITE_URL}guide/en/siem/guide/${services.docLinks.DOC_LINK_VERSION}/conf-map-ui.html`}
href={`${services.docLinks.ELASTIC_WEBSITE_URL}guide/en/security/${services.docLinks.DOC_LINK_VERSION}/conf-map-ui.html`}
target="_blank"
>
{i18n.EMBEDDABLE_HEADER_HELP}
Expand Down