-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover] Improve Discover histogram time range tests #71056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kertal
merged 5 commits into
elastic:master
from
kertal:kertal-pr-2020-06-08-improve-discover-histogram-test
Jul 9, 2020
Merged
[Discover] Improve Discover histogram time range tests #71056
kertal
merged 5 commits into
elastic:master
from
kertal:kertal-pr-2020-06-08-improve-discover-histogram-test
Jul 9, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dmlemeshko
approved these changes
Jul 9, 2020
Member
dmlemeshko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 9, 2020
* Improve Discover histogram tests * Use includes function to find a string Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kertal
added a commit
that referenced
this pull request
Jul 9, 2020
2 tasks
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 30, 2020
* Improve Discover histogram tests * Use includes function to find a string Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # test/functional/apps/discover/_discover.js
kertal
added a commit
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
v6.8.12
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding more stability to Discover histogram test to prevent flakiness.
Fixes #55798
Checklist