Skip to content

[SECURITY] Bug nav link not hidden #70607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2020
Merged

[SECURITY] Bug nav link not hidden #70607

merged 3 commits into from
Jul 6, 2020

Conversation

@XavierM
Copy link
Contributor

@XavierM XavierM commented Jul 2, 2020

Summary

This PR is there to resolve this #69798, However we are waiting on this PR to be merged first #70538

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 2, 2020
@XavierM XavierM requested a review from legrego July 2, 2020 14:45
@XavierM XavierM requested review from a team as code owners July 2, 2020 14:45
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 2, 2020

Pinging @elastic/siem (Team:SIEM)

cnasikas
cnasikas approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! I tested locally. I created a user with access only to Canvas. Logged in and the security navigation links weren't exposed to the user.

legrego
legrego approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 6, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit da602fc into elastic:master Jul 6, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Jul 6, 2020
@XavierM
fix nav link to be hidden and update access tag (elastic#70607)
5dcd654
@XavierM XavierM mentioned this pull request Jul 6, 2020
Merged
XavierM added a commit that referenced this pull request Jul 6, 2020
@XavierM
fix nav link to be hidden and update access tag (#70607) (#70861)
ef3934c
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legrego legrego legrego approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XavierM @elasticmachine @kibanamachine @legrego @cnasikas @MindyRS