-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[APM]Create API to return data to be used on the Overview page #69137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2e30c9 to
0669af8
Compare
37ad1f9 to
1188e7f
Compare
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
Author
|
retest |
sorenlouv
reviewed
Jun 24, 2020
Member
sorenlouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good overall 👍
x-pack/plugins/apm/server/lib/observability_dashboard/get_service_count.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/observability_dashboard/has_data.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/observability_dashboard/get_transaction_coordinates.ts
Show resolved
Hide resolved
Contributor
Author
|
retest |
1 similar comment
Contributor
Author
|
retest |
sorenlouv
reviewed
Jun 24, 2020
sorenlouv
approved these changes
Jun 24, 2020
Contributor
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Jun 26, 2020
…ic#69137) * Adding apm data fetcher * removing error rate * chaging observability dashboard routes * APM observability fetch data * fixing imports * adding unit test * addressing PR comments * adding processor event in the query, and refactoring theme * fixing ts issues * fixing unit tests
cauemarcondes
added a commit
that referenced
this pull request
Jun 26, 2020
… (#70049) * Adding apm data fetcher * removing error rate * chaging observability dashboard routes * APM observability fetch data * fixing imports * adding unit test * addressing PR comments * adding processor event in the query, and refactoring theme * fixing ts issues * fixing unit tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 26, 2020
* master: (34 commits) Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054) [License Management] Do not break when `telemetry.enabled:false` (elastic#69711) [SECURITY] Redirect app/security to app/security/overview (elastic#70005) "Explore underlying data" in-chart action (elastic#69494) Api reference docs for state_containers and state_sync (elastic#67354) prep state transfer for passing embeddables by value to editor and back (elastic#69991) move Metrics API to start (elastic#69787) refactor: 💡 fix typo in embeddable (elastic#69417) [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982) [APM]Create API to return data to be used on the Overview page (elastic#69137) [Lens] Fix delete button position in dimension panel for long labels (elastic#69495) [Lens] Add toolbar api (elastic#69263) Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Observability Landing - Milestone 1
release_note:enhancement
Team:APM - DEPRECATED
Use Team:obs-ux-infra_services.
v7.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registry
fetchDataandhasDatafunctions to the Observability dashboard.FYI: We're skipping the error rate for now.