-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[RFC][Search] Background sessions RFC #69117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
| The main component of this RFC is the background session service. | ||
|
|
||
| It is a server side service, that tracks and stores sessions and all associated requests. | ||
| When a user starts executing a session, the service stores information in memory, until the user decides to "Send to Background" or until the expiration time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this happen over multiple HTTP requests? When Kibana is deployed behind a load-balancer in a highly-available deployment, multiple HTTP requests will likely be served by multiple different instances of Kibana with different "memory".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be one saved object, but multiple servers may be updating the saved object (depending on where search requests are routed).
| The main component of this RFC is the background session service. | ||
|
|
||
| It is a server side service, that tracks and stores sessions and all associated requests. | ||
| When a user starts executing a session, the service stores information in memory, until the user decides to "Send to Background" or until the expiration time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that at least some aspect of background sessions will be "per user", how will these be persisted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll store a hash of the username in the saved object itself, which we will use to filter the list we display to the user. While the saved objects themselves will be persisted to the user's space, we don't anticipate that to be an issue since we're storing a hash of the request/search IDs, not the search results themselves.
|
Replaced by #73281 |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers