Skip to content

Conversation

@lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 14, 2020

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom requested a review from lukasolson June 14, 2020 15:19
@lizozom lizozom self-assigned this Jun 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This PR does not require backporting labels Jun 14, 2020
The main component of this RFC is the background session service.

It is a server side service, that tracks and stores sessions and all associated requests.
When a user starts executing a session, the service stores information in memory, until the user decides to "Send to Background" or until the expiration time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this happen over multiple HTTP requests? When Kibana is deployed behind a load-balancer in a highly-available deployment, multiple HTTP requests will likely be served by multiple different instances of Kibana with different "memory".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be one saved object, but multiple servers may be updating the saved object (depending on where search requests are routed).

The main component of this RFC is the background session service.

It is a server side service, that tracks and stores sessions and all associated requests.
When a user starts executing a session, the service stores information in memory, until the user decides to "Send to Background" or until the expiration time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that at least some aspect of background sessions will be "per user", how will these be persisted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll store a hash of the username in the saved object itself, which we will use to filter the list we display to the user. While the saved objects themselves will be persisted to the user's space, we don't anticipate that to be an issue since we're storing a hash of the request/search IDs, not the search results themselves.

@lizozom lizozom mentioned this pull request Jul 13, 2020
32 tasks
@lizozom
Copy link
Contributor Author

lizozom commented Jul 27, 2020

Replaced by #73281

@lizozom lizozom closed this Jul 27, 2020
@lizozom lizozom reopened this Aug 17, 2020
@lukasolson lukasolson closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes RFC v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants