-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[SIEM][Exceptions] Add success/error toast component on alert state change #67406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find any mocks specifying wording here, open for suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capitalization, grammar, etc. also on the board
|
Pinging @elastic/endpoint-response (Team:Endpoint Response) |
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
|
(jenkins upgrade required killing all jobs) |
a2566cd to
469f30b
Compare
|
Can you justify the need for a toast here? Here's my thoughts: I'm assuming that when the user takes certain actions on an alert, the application optimistically assumes that things worked out. If the action has a very low chance of failing, this approach improves the flow for users dramatically. I'm also assuming that a toast is a good pattern when there is new information that the user will act on. So with those ideas in mind, I'm arguing that this is not a good use case for a toast. If the user already assumed that the action was successful, then showing a toast to left them know that it was successful provides no actionable info for them. I'm arguing that they won't do anything different except learn to ignore the toast. They were already taking whatever actions having assumed that they successfully opened alerts. Other thoughts:
When I think a toast would be good:
Please consider my ideas even if you choose to merge. Thanks |
|
@oatkiller I think those are good thoughts to bring up. From what I can gather in the ticket and our use case, I think the desired effect of a confirmation is still useful. It provides, namely, the ability to verify the number of alerts being closed/opened is correct, and it's been discussed to add an "undo" button in the success toast in the future to perhaps revert that action instantly if the quantity the user expected didn't match up. I think there's something to be said still for the args you bring up though, lets discuss further |
|
Davis and I talked and came up w/ an argument for the toast:
@peluja1012 do these reasons match up w/ your thoughts? |
@oatkiller That makes sense to me. |
|
@oatkiller thanks for your insight to toaster usage. I do think it's expected for users to receive a confirmation message on number of alerts they closed/opened/put in progress. Currently the user can accidentally close an alert and it just disappears from the list they are seeing. User has no idea where that alert went if they didn't notice they chose the action of "close alert". I think it's fine for the toaster to be ignored for the most part, but useful for when the user actually want to make sure N number of alerts has been reopened or closed - much like when you delete an email in Gmail, you get a small toaster "# of email deleted, click to undo". If toaster is not the best UI solution to confirm the action, do you have an alternative suggestion for the team? CC: @peluja1012 |
|
@oatkiller @dplumlee would it be possible to make the toaster show error messages as well? Not just success message. I think then it maximizes the usage of the toaster. |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
x-pack/plugins/siem/public/alerts/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/siem/public/alerts/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
spong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out, tested locally, and performed code review. Overall looks good, but I found an issue where the updated count in the toasts were incorrect when using the select all bulk action. Grabbing the count from the response should resolve this bug.
This also uncovered a separate bug where we're not providing the current status filter (open/closed) in the update_by_query call, but that can be addressed in a separate issue/PR.
30271e0 to
de5ca86
Compare
x-pack/plugins/siem/public/alerts/containers/detection_engine/signals/api.ts
Show resolved
Hide resolved
spong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Thanks for the fix and cleanup -- looks great! 🙂
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/spaces/spaces_selection·ts.Spaces app Spaces Spaces Data displays separate data for each space in a custom spaceStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
…hange (elastic#67406) ## Summary Adds a success and error toast on open or close of alert(s). elastic#65947 <img width="1035" alt="Screen Shot 2020-05-26 at 2 28 57 PM" src="https://user-images.githubusercontent.com/56367316/82947446-5086ae00-9f5d-11ea-848a-9edae48c47dc.png"> <img width="1022" alt="Screen Shot 2020-05-28 at 12 01 03 PM" src="https://user-images.githubusercontent.com/56367316/83176760-3f63ab80-a0db-11ea-9f4d-7b745d0b4bf0.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
…hange (#67406) (#68095) ## Summary Adds a success and error toast on open or close of alert(s). #65947 <img width="1035" alt="Screen Shot 2020-05-26 at 2 28 57 PM" src="https://user-images.githubusercontent.com/56367316/82947446-5086ae00-9f5d-11ea-848a-9edae48c47dc.png"> <img width="1022" alt="Screen Shot 2020-05-28 at 12 01 03 PM" src="https://user-images.githubusercontent.com/56367316/83176760-3f63ab80-a0db-11ea-9f4d-7b745d0b4bf0.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Adds a success and error toast on open or close of alert(s). #65947
Checklist
Delete any items that are not applicable to this PR.
For maintainers