Lens client side shim cleanup #56976

flash1293 · 2020-02-06T14:01:21Z

This PR cleans up the plugin shim to prepare the migration to the new platform.

Pass down dependencies from the root plugin to all visualizations and datasources
Remove direct legacy imports in favor of passed down services where possible
Move actual legacy dependencies either into a __LEGACY plugin or into legacy_imports

I had to change one thing in the API because the indexpattern datasource needs start contracts for some things. I solved this by allowing a promise of a datasource/visualization definition as well when registering.

While everything is initialized from a central top level plugin instance, I still kept the general structure of services that are shaped like plugins - this will make it easy to break out individual parts into separate plugins if we ever decide to do so.

flash1293 · 2020-02-06T15:37:03Z

Jenkins, test this.

elasticmachine · 2020-02-07T13:09:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b18f96f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-07T13:27:41Z

Pinging @elastic/kibana-app (Team:KibanaApp)

cchaos

There are a few inconsistencies with our SASS patterns, but those existed before and I can fix those in a follow up. Other than that the file renames LGTM 👍

wylieconlon · 2020-02-11T18:51:05Z

x-pack/legacy/plugins/lens/public/editor_frame_service/service.tsx

+    definitions.map(definition =>
+      definition instanceof Promise ? definition : Promise.resolve(definition)
+    )
+  );


Promise.all can take non-Promise objects and passes them through automatically. I think this is equivalent to:

const resolvedDefinitions = await Promise.all(definitions);

Wow thanks, TIL.

wylieconlon

Overall, changes LGTM! I previously left one comment but it's a nitpick.

kibanamachine · 2020-02-13T12:50:31Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 9a414f8
Flaky suites:
- xpack-kibana-ciGroup2

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management home

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/57377

[00:00:00]       │
[00:00:00]         └-: Advanced Settings
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: security feature controls
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook
[00:00:00]               │ info [empty_kibana] Loading "mappings.json"
[00:00:00]               │ info [empty_kibana] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_1/CL92jNucRt-OosSdrx0l1w] deleting index
[00:00:00]               │ info [empty_kibana] Deleted existing index [".kibana_1"]
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:00]               │ info [empty_kibana] Created index ".kibana"
[00:00:00]               │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:00]               │ info [empty_kibana] Indexed 2 docs into ".kibana"
[00:00:39]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana/WYFkgh1DRV69VLZjt1dxLQ] update_mapping [_doc]
[00:00:41]               │ info Creating index .kibana_2.
[00:00:41]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:41]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:41]               │ info Reindexing .kibana to .kibana_1
[00:00:41]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:41]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:41]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:41]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] updating number_of_replicas to [0] for indices [.tasks]
[00:00:42]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] 779 finished with response BulkByScrollResponse[took=71.8ms,timed_out=false,sliceId=null,updated=0,created=4,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:42]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana/WYFkgh1DRV69VLZjt1dxLQ] deleting index
[00:00:42]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:00:42]               │ debg Migrating saved objects config:6.0.0-alpha1, space:default, maps-telemetry:maps-telemetry, config:8.0.0-SNAPSHOT
[00:00:42]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_2/XV8tqw2NRDyTvtlhqdw5qw] update_mapping [_doc]
[00:00:42]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_2/XV8tqw2NRDyTvtlhqdw5qw] update_mapping [_doc]
[00:00:42]               │ info Pointing alias .kibana to .kibana_2.
[00:00:42]               │ info Finished in 841ms.
[00:00:42]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:42]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] [.kibana_2/XV8tqw2NRDyTvtlhqdw5qw] update_mapping [_doc]
[00:02:50]             └-: no advanced_settings privileges
[00:02:50]               └-> "before all" hook
[00:02:50]               └-> "before all" hook
[00:02:50]                 │ debg creating role no_advanced_settings_privileges_role
[00:02:50]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] added role [no_advanced_settings_privileges_role]
[00:02:50]                 │ debg created role no_advanced_settings_privileges_role
[00:02:50]                 │ debg creating user no_advanced_settings_privileges_user
[00:02:50]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-centos-tests-xl-1581592307533976452] added user [no_advanced_settings_privileges_user]
[00:02:50]                 │ debg created user no_advanced_settings_privileges_user
[00:02:50]                 │ debg navigating to login url: http://localhost:6131/login
[00:02:50]                 │ debg Navigate to: http://localhost:6131/login
[00:02:50]                 │ proc [kibana]   log   [11:48:59.095] [info][authentication][plugins][security] Authentication attempt failed: [security_exception] unable to authenticate user [global_advanced_settings_read_user] for REST request [/_security/_authenticate], with { header={ WWW-Authenticate="Basic realm=\"security\" charset=\"UTF-8\"" } }
[00:02:50]                 │ debg ... sleep(700) start
[00:02:50]                 │ERROR browser[SEVERE] http://localhost:6131/ - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:02:51]                 │ debg ... sleep(700) end
[00:02:51]                 │ debg returned from get, calling refresh
[00:02:51]                 │ debg browser[INFO] http://localhost:6131/login?next=%2F 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:51]                 │
[00:02:51]                 │ debg browser[INFO] http://localhost:6131/bundles/app/login/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:51]                 │ debg currentUrl = http://localhost:6131/login?next=%2F
[00:02:51]                 │          appUrl = http://localhost:6131/login
[00:02:51]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:56]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-13T11:49:04Z
[00:02:56]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:02:56]                 │
[00:02:56]                 │      "
[00:02:56]                 │ debg ... sleep(501) start
[00:02:57]                 │ debg ... sleep(501) end
[00:02:57]                 │ debg in navigateTo url = http://localhost:6131/login?next=%2F#/
[00:02:57]                 │ debg TestSubjects.exists(statusPageContainer)
[00:02:57]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:59]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:03:00]                 │ debg TestSubjects.setValue(loginUsername, no_advanced_settings_privileges_user)
[00:03:00]                 │ debg TestSubjects.click(loginUsername)
[00:03:00]                 │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:03:00]                 │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:03:00]                 │ debg TestSubjects.setValue(loginPassword, no_advanced_settings_privileges_user-password)
[00:03:00]                 │ debg TestSubjects.click(loginPassword)
[00:03:00]                 │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:03:00]                 │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:03:01]                 │ debg TestSubjects.click(loginSubmit)
[00:03:01]                 │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:03:01]                 │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:03:01]                 │ debg Waiting up to 20000ms for logout button visible...
[00:03:01]                 │ debg TestSubjects.exists(userMenuButton)
[00:03:01]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:03:04]                 │ debg browser[INFO] http://localhost:6131/app/kibana#/ 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:04]                 │
[00:03:04]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:04]                 │ debg --- retry.tryForTime error: [data-test-subj="userMenuButton"] is not displayed
[00:03:05]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-13T11:49:14Z
[00:03:05]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:05]                 │
[00:03:05]                 │      "
[00:03:05]                 │ debg TestSubjects.exists(userMenuButton)
[00:03:05]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:03:07]                 │ debg TestSubjects.exists(userMenu)
[00:03:07]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:03:09]                 │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:03:10]                 │ debg TestSubjects.click(userMenuButton)
[00:03:10]                 │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:03:10]                 │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:03:10]                 │ debg Waiting up to 20000ms for user menu opened...
[00:03:10]                 │ debg TestSubjects.exists(userMenu)
[00:03:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:03:10]                 │ debg TestSubjects.exists(userMenu > logoutLink)
[00:03:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:03:10]               └-> shows Management navlink
[00:03:10]                 └-> "before each" hook: global before each
[00:03:10]                 │ debg TestSubjects.find(navDrawer)
[00:03:10]                 │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:03:10]                 └- ✓ pass  (31ms) "Advanced Settings security feature controls no advanced_settings privileges shows Management navlink"
[00:03:10]               └-> does not allow navigation to advanced settings; redirects to management home
[00:03:10]                 └-> "before each" hook: global before each
[00:03:10]                 │ debg navigateToActualUrl http://localhost:6131/app/kibana#management/kibana/settings
[00:03:10]                 │ debg browser[INFO] http://localhost:6131/app/kibana?_t=1581594558955#management/kibana/settings 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:10]                 │
[00:03:10]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:10]                 │ debg TestSubjects.exists(managementHome)
[00:03:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="managementHome"]') with timeout=10000
[00:03:14]                 │ debg --- retry.tryForTime error: [data-test-subj="managementHome"] is not displayed
[00:03:15]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-13T11:49:23Z
[00:03:15]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:15]                 │
[00:03:15]                 │      "
[00:03:20]                 │ debg browser[INFO] http://localhost:6131/app/kibana#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:20]                 │
[00:03:20]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:20]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-13T11:49:28Z
[00:03:20]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:20]                 │
[00:03:20]                 │      "
[00:03:20]                 │ debg --- retry.tryForTime failed again with the same message...
[00:03:21]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings_ redirects to management home.png"
[00:03:22]                 │ info Current URL is: http://localhost:6131/app/kibana#/management?_g=()
[00:03:22]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings_ redirects to management home.html
[00:03:23]                 └- ✖ fail: "Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management home"
[00:03:23]                 │

Stack Trace

Error: expected testSubject(managementHome) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

History

💛 Build #25998 was flaky 1898f55
💚 Build #25828 succeeded d926889
💚 Build #25213 succeeded b18f96f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx

* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...

flash1293 added 4 commits February 5, 2020 18:36

WIP cleanup

ac5de37

Merge remote-tracking branch 'upstream/master' into lens-cleanup

265027f

wip

0a99d4f

wip

10dc77a

flash1293 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Feature:NP Migration v7.7.0 labels Feb 6, 2020

flash1293 added 4 commits February 6, 2020 15:01

Merge remote-tracking branch 'upstream/master' into lens-cleanup

d095e6d

fix type errors

004c77e

fix type errors

2e4cda0

only start editor frame service once

68915a5

flash1293 added 3 commits February 6, 2020 16:44

improve naming

16d13a4

Merge remote-tracking branch 'upstream/master' into lens-cleanup

07d101e

make create instance async and move registration into separate services

b18f96f

flash1293 marked this pull request as ready for review February 7, 2020 13:27

flash1293 requested a review from a team February 7, 2020 13:27

flash1293 requested a review from a team as a code owner February 7, 2020 13:27

flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 7, 2020

flash1293 requested review from 1stvamp, drawlerr and wylieconlon and removed request for 1stvamp and drawlerr February 7, 2020 13:27

flash1293 mentioned this pull request Feb 11, 2020

[Lens] Create filters on click with bar, line, area charts #57261

Merged

1 task

Merge remote-tracking branch 'upstream/master' into lens-cleanup

d926889

cchaos approved these changes Feb 11, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into HEAD

25422c2

wylieconlon added 2 commits February 11, 2020 14:17

Merge remote-tracking branch 'origin/master' into HEAD

c9b851c

Fix type errors

1898f55

wylieconlon reviewed Feb 11, 2020

View reviewed changes

wylieconlon approved these changes Feb 11, 2020

View reviewed changes

flash1293 added 2 commits February 13, 2020 11:59

Merge remote-tracking branch 'upstream/master' into lens-cleanup

1335837

simplify code

9a414f8

flash1293 merged commit 4437858 into elastic:master Feb 13, 2020

flash1293 deleted the lens-cleanup branch February 13, 2020 12:54

flash1293 mentioned this pull request Feb 13, 2020

[7.x] Lens client side shim cleanup (#56976) #57562

Merged

flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 13, 2020

Lens client side shim cleanup (elastic#56976)

b6077d3

flash1293 added a commit that referenced this pull request Feb 13, 2020

Lens client side shim cleanup (#56976) (#57562)

b8b275f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lens client side shim cleanup #56976

Lens client side shim cleanup #56976

flash1293 commented Feb 6, 2020 •

edited

Loading

flash1293 commented Feb 6, 2020

elasticmachine commented Feb 7, 2020

elasticmachine commented Feb 7, 2020

cchaos left a comment

wylieconlon Feb 11, 2020

flash1293 Feb 13, 2020

wylieconlon left a comment

kibanamachine commented Feb 13, 2020

Standard Out

Stack Trace

Lens client side shim cleanup #56976

Lens client side shim cleanup #56976

Conversation

flash1293 commented Feb 6, 2020 • edited Loading

flash1293 commented Feb 6, 2020

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

elasticmachine commented Feb 7, 2020

cchaos left a comment

Choose a reason for hiding this comment

wylieconlon Feb 11, 2020

Choose a reason for hiding this comment

flash1293 Feb 13, 2020

Choose a reason for hiding this comment

wylieconlon left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 13, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

flash1293 commented Feb 6, 2020 •

edited

Loading