[Uptime] Added tests for pages #56736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:fix
v7.7.0
v8.0.0
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
requested review from
111andre111 and
andrewvc
and removed request for
111andre111
Contributor
Author
|
@justinkambic this is also ready for review !! |
justinkambic
reviewed
Feb 7, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
This looks good - I had a recommendation on how we can reduce the footprint of the router test helpers this introduces.
x-pack/legacy/plugins/uptime/public/pages/__tests__/page_header.test.tsx
Show resolved
Hide resolved
Contributor
Author
|
@justinkambic took care of PR feedback |
justinkambic
approved these changes
Feb 11, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
LGTM - resolve conflicts and WFG
Contributor
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 12, 2020
* master: [Canvas] Move sample data and feature registration to canvas np plugin (elastic#56564) instrument task manager with apm transactions (elastic#55356) displays Alert Instance state on Alert Details page (elastic#56842) Adding the Accessibility Statement to docs (elastic#57153) [Uptime] Remove redundant adapter function (elastic#56980) [SIEM][Detection Engine] Backend end-to-end tests [Uptime] Added tests for pages (elastic#56736) Updating to kind-of@6.0.3 (elastic#57367)
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Feb 13, 2020
* added test for pages * fixed types * update types * update snap * PR feedback * PR feedback
shahzad31
added a commit
that referenced
this pull request
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#136
Added test for missing page components.