Use mapbox-gl-draw/dist for IE11 support #36505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
|
Pinging @elastic/kibana-operations |
Contributor
Author
|
@spalger curious if there is another suggestion for the handling of this package. |
Contributor
💚 Build Succeeded |
thomasneirynck
approved these changes
May 11, 2019
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
I wasn't able to test this on IE11 now (need to setup that environment first), but verified everything continues to work as expected.
snide
approved these changes
May 20, 2019
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
I verified this does work in IE11. We'll likely want to merge this before FF tomorrow.
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
May 20, 2019
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
May 20, 2019
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package publishes it's transpiled code in a dist directory without updating
the package.json's main to point to this file. Since we do not transpile node
modules, we are updating the require statement to explicitly point to this
file.
Related: #33686