Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useUTC deprecation, set default timezone to local #22696

Merged
merged 6 commits into from
Mar 29, 2019
Merged

remove useUTC deprecation, set default timezone to local #22696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5035d0
remove useUTC deprecation, set default timezone to local
jbudz Sep 4, 2018
604d9a2
Merge branch 'master' into server-tz-local
jbudz Jan 24, 2019
8565fa8
no-unused-vars
jbudz Jan 25, 2019
062f4e7
Merge branch 'master' into server-tz-local
jbudz Feb 25, 2019
acfcd79
Merge branch 'master' into server-tz-local
jbudz Mar 26, 2019
ca5511f
rm set, unset import
jbudz Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/migration/migrate_7_0.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,9 @@ considered unique based on its persistent UUID, which is written to the path.dat
*Details:* Any timezone can now be specified by canonical id.

*Impact:* The logging.useUTC flag will have to be replaced with a timezone id. If set to true the id is `UTC`.

[float]
=== Default logging timezone is now the system's timezone
*Details:* In prior releases the timezone used in logs defaulted to UTC. We now use the host machine's timezone by default.

*Impact:* To restore the previous behavior, in kibana.yml set `logging.timezone: UTC`.
2 changes: 1 addition & 1 deletion src/server/config/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default () => Joi.object({
then: Joi.default(!process.stdout.isTTY),
otherwise: Joi.default(true)
}),
timezone: Joi.string().allow(false).default('UTC')
timezone: Joi.string().allow(false).default(false)
Copy link
Member Author

@jbudz jbudz Sep 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by false this means don't set it, which uses moments default (local timezone). i was hesitant to add a non-standard string to the list.

}).default(),

ops: Joi.object({
Expand Down
10 changes: 0 additions & 10 deletions src/server/config/transform_deprecations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,6 @@ const rewriteBasePath = (settings, log) => {
}
};

const loggingTimezone = (settings, log) => {
if (_.has(settings, 'logging.useUTC')) {
const timezone = settings.logging.useUTC ? 'UTC' : false;
set('logging.timezone', timezone);
unset(settings, 'logging.UTC');
log(`Config key "logging.useUTC" is deprecated. It has been replaced with "logging.timezone"`);
}
};

const deprecations = [
//server
rename('server.ssl.cert', 'server.ssl.certificate'),
Expand All @@ -78,7 +69,6 @@ const deprecations = [
serverSslEnabled,
savedObjectsIndexCheckTimeout,
rewriteBasePath,
loggingTimezone,
];

export const transformDeprecations = createTransform(deprecations);