[Reporting] Remove kibana version from report flyout in serverless #196670
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
|
tsullivan
requested changes
Oct 18, 2024
| const { apiClient } = useInternalApiClient(); | ||
| const isServerless = apiClient.getIsServerless(); |
There was a problem hiding this comment.
The overall changes in this PR can be simplified, since there already is an indication of whether the deployment is serverless in the config.statefulSettings.enabled value, and the config object is in scope here
| @@ -139,7 +141,7 @@ export const ReportInfoFlyout: FunctionComponent<Props> = ({ config, onClose, jo | |||
| {isLoading ? ( | |||
| <EuiLoadingSpinner /> | |||
| ) : loadingError ? undefined : !!info ? ( | |||
| <ReportInfoFlyoutContent info={info} /> | |||
| <ReportInfoFlyoutContent info={info} isServerless={isServerless} /> | |||
There was a problem hiding this comment.
- Let's change this to passing the
ClientConfigTypeobject
Suggested change
| <ReportInfoFlyoutContent info={info} isServerless={isServerless} /> | |
| <ReportInfoFlyoutContent info={info} config={config} /> |
| @@ -33,14 +33,15 @@ const UNKNOWN = i18n.translate('xpack.reporting.listing.infoPanel.unknownLabel', | |||
|
|
|||
| interface Props { | |||
| info: Job; | |||
| isServerless: boolean; | |||
There was a problem hiding this comment.
- Let's have this expect the
ClientConfigTypeobject
Suggested change
| isServerless: boolean; | |
| config: ClientConfigType; |
| } | ||
|
|
||
| const createDateFormatter = (format: string, tz: string) => (date: string) => { | ||
| const m = moment.tz(date, tz); | ||
| return m.isValid() ? m.format(format) : NA; | ||
| }; | ||
|
|
||
| export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info }) => { | ||
| export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info, isServerless }) => { |
There was a problem hiding this comment.
Suggested change
| export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info, isServerless }) => { | |
| export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info, config }) => { |
| @@ -50,6 +51,8 @@ export const ReportInfoFlyoutContent: FunctionComponent<Props> = ({ info }) => { | |||
| ? moment.tz.guess() | |||
| : uiSettings.get('dateFormat:tz'); | |||
|
|
|||
| const showKibanaVersion = Boolean(info.version) && !isServerless; | |||
There was a problem hiding this comment.
- Let's use the
configobject to determine this flag
Suggested change
| const showKibanaVersion = Boolean(info.version) && !isServerless; | |
| const showKibanaVersion = Boolean(info.version) && config.statefulSettings.enabled; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
Kibana Versionfrom report flyout in serverless.Fixes: #196000
Visuals
Checklist