[plugin installer] Allow x-pack removal if it exists #19327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
/cc @elastic/kibana-operations |
tylersmalley
approved these changes
May 31, 2018
|
Should be able to resolve the conflicts by running |
mistic
approved these changes
Jun 1, 2018
💔 Build Failed |
|
retest |
💚 Build Succeeded |
jbudz
added a commit
that referenced
this pull request
Jun 8, 2018
* [plugin installer] Allow x-pack removal if it exists * remove lingering exit
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jun 15, 2018
* [plugin installer] Allow x-pack removal if it exists * remove lingering exit
jbudz
added a commit
that referenced
this pull request
Jun 15, 2018
|
@jbudz just updated your last comment to include the merge hash for the backport PR to 6.3.1 😃 |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
* [plugin installer] Allow x-pack removal if it exists * remove lingering exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing an in-place upgrade from an install with x-pack to the default distribution in 6.3, an old x-pack install is unable to be removed with the plugin installer after upgrading. This lets the plugin installer remove plugins/x-pack regardless of distribution if it exists.
This also rewrites the tests to jest. At some point between when this was written and merged, the other tests were updated, so this gets the rest up to speed.
To test, in the distribution including x-pack:
bin/kibana-plugin remove x-packwith an x-pack plugin in the plugins folder should remove the pluginbin/kibana-plugin remove x-packwithout an x-pack plugin should messageYou are using the standard distrbution of Kibana. Please install the OSS-only distribution to remove X-Pack features.Part of #18813