Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cdccbf1
Update dependency @elastic/charts to v63
renovate[bot] Jan 24, 2024
c9ddea4
comment out all showLegendExtra breaking usages
markov00 Jan 26, 2024
2dc6e08
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Jan 26, 2024
0abcf94
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Jan 26, 2024
130660f
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Jan 29, 2024
39b8b8f
disable showLegendExtra in a couple of more places
markov00 Jan 29, 2024
963391c
setting false instead of removing the prop
markov00 Jan 29, 2024
bcbfb00
Merge branch 'main' into renovate/main-@elasticcharts
stratoula Jan 29, 2024
8e84c98
Update request for Watcher chart
ElenaStoeva Feb 2, 2024
def2ab1
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Feb 5, 2024
e6a4e1e
checked APM charts and they work as expected
markov00 Feb 1, 2024
0ed8314
No issue with infra chart_selection
markov00 Feb 5, 2024
2325734
Correctly pass data to security solution charts
markov00 Feb 6, 2024
b279d40
checked alerts histogram and data is passed correctly
markov00 Feb 6, 2024
8d1a73d
checked matrix histogram and data is passed with empty buckets
markov00 Feb 6, 2024
ab444fb
add empty as null on time series
markov00 Feb 7, 2024
e260429
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Feb 7, 2024
dfede06
update snapshots
markov00 Feb 7, 2024
f16ebdd
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Feb 7, 2024
91b0298
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Feb 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"@dnd-kit/utilities": "^2.0.0",
"@elastic/apm-rum": "^5.16.0",
"@elastic/apm-rum-react": "^2.0.2",
"@elastic/charts": "61.2.0",
"@elastic/charts": "63.0.0",
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.9.1-canary.1",
"@elastic/ems-client": "8.5.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ export function LogsSection({ bucketSize }: Props) {
showLegend
legendPosition={Position.Right}
xDomain={{ min, max }}
showLegendExtra
// Please double check if the data passed to the chart contains all the buckets, even the empty ones.
// the showLegendExtra will display the last element of the data array as the default legend value
// and if empty buckets are filtered out you can probably see a value that doesn't correspond
// to the value in the last time bucket visualized.
// showLegendExtra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I'm not wrong the query for this chart is built in buildLogOverviewAggregations from x-pack/plugins/infra/public/utils/logs_overview_fetchers.ts and this doesn't contain the min_doc_count:0 and the extended_bounds. Turning this off for now, but can be turned as soon as the query builder is fixed

locale={i18n.getLocale()}
/>
{series &&
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export const getAlertsHistogramLensAttributes: GetLensAttributes = (
scale: 'interval',
params: {
interval: 'auto',
includeEmptyRows: true,
},
},
'e09e0380-0740-4105-becc-0a4ca12e3944': {
Expand All @@ -79,6 +80,7 @@ export const getAlertsHistogramLensAttributes: GetLensAttributes = (
isBucketed: false,
scale: 'ratio',
sourceField: '___records___',
params: { emptyAsNull: true },
},
'34919782-4546-43a5-b668-06ac934d3acd': {
label: `Top values of ${stackByField}`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export const getEventsHistogramLensAttributes: GetLensAttributes = (
scale: 'interval',
params: {
interval: 'auto',
includeEmptyRows: true,
},
},
'e09e0380-0740-4105-becc-0a4ca12e3944': {
Expand All @@ -80,6 +81,7 @@ export const getEventsHistogramLensAttributes: GetLensAttributes = (
isBucketed: false,
scale: 'ratio',
sourceField: '___records___',
params: { emptyAsNull: true },
},
'34919782-4546-43a5-b668-06ac934d3acd': {
label: `Top values of ${stackByField}`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export const getExternalAlertLensAttributes: GetLensAttributes = (
scale: 'interval',
params: {
interval: 'auto',
includeEmptyRows: true,
},
},
'0a923af2-c880-4aa3-aa93-a0b9c2801f6d': {
Expand All @@ -100,6 +101,7 @@ export const getExternalAlertLensAttributes: GetLensAttributes = (
isBucketed: false,
scale: 'ratio',
sourceField: '___records___',
params: { emptyAsNull: true },
},
'42334c6e-98d9-47a2-b4cb-a445abb44c93': {
label: TOP_VALUE(`${stackByField}`), // could be event.category
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export const getDnsTopDomainsLensAttributes: GetLensAttributes = (
scale: 'interval',
params: {
interval: 'auto',
includeEmptyRows: true,
},
},
'2a4d5e20-f570-48e4-b9ab-ff3068919377': {
Expand All @@ -142,6 +143,7 @@ export const getDnsTopDomainsLensAttributes: GetLensAttributes = (
scale: 'ratio',
sourceField: 'dns.question.name',
isBucketed: false,
params: { emptyAsNull: true },
},
},
columnOrder: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,11 @@ export const ThresholdVisualization: React.FunctionComponent<Props> = ({
baseTheme={chartsBaseTheme}
xDomain={domain}
showLegend={!!termField}
showLegendExtra
// Please double check if the data passed to the chart contains all the buckets, even the empty ones.
// the showLegendExtra will display the last element of the data array as the default legend value
// and if empty buckets are filtered out you can probably see a value that doesn't correspond
// to the value in the last time bucket visualized.
// showLegendExtra
legendPosition={Position.Bottom}
locale={i18n.getLocale()}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ export const DurationChartComponent = ({
<Settings
xDomain={{ min, max }}
showLegend
showLegendExtra
// Please double check if the data passed to the chart contains all the buckets, even the empty ones.
// the showLegendExtra will display the last element of the data array as the default legend value
// and if empty buckets are filtered out you can probably see a value that doesn't correspond
// to the value in the last time bucket visualized.
// showLegendExtra
legendPosition={Position.Right}
onBrushEnd={onBrushEnd}
onLegendItemClick={legendToggleVisibility}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ export function buildVisualizeQuery(watch, visualizeOptions, kibanaVersion) {
date_histogram: {
field: watch.timeField,
time_zone: visualizeOptions.timezone,
min_doc_count: 1,
min_doc_count: 0,
extended_bounds: {
min: visualizeOptions.rangeFrom,
max: visualizeOptions.rangeTo,
},
},
};

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1658,10 +1658,10 @@
dependencies:
object-hash "^1.3.0"

"@elastic/charts@61.2.0":
version "61.2.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-61.2.0.tgz#fa065b85324d5660e4b6355390cca8699ef0d6ff"
integrity sha512-LBmZ+6wSR9/BCR+go5eIBy51Jpxr0cbK/a7vslZNYIGCdpHsWxGZgcqG3KgshFxOmUvcP7kj9LEEmeCTEGhbUQ==
"@elastic/charts@63.0.0":
version "63.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-63.0.0.tgz#c7f54cd60a1a59a28b5654886392e05a10fd67b8"
integrity sha512-nvLg/qFJXYuKOdTDYj3iuwJ/X4zhkHdIB91yezd7fo+YvpBRiAUzJfc6Dpy6M5JkmGwx7Dq8zjGt6mO8ngOhog==
dependencies:
"@popperjs/core" "^2.11.8"
bezier-easing "^2.1.0"
Expand Down