[Flaky #70928] Unskip test #166177
Merged
[Flaky #70928] Unskip test #166177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
pgayvallet
approved these changes
Sep 13, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit df08786)
This was referenced Sep 13, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit df08786)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[Flaky #70928] Unskip test (#166177)](#166177) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-09-13T07:06:05Z","message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Security","technical debt","release_note:skip","backport:all-open","v8.11.0"],"number":166177,"url":"https://github.com/elastic/kibana/pull/166177","mergeCommit":{"message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166177","number":166177,"mergeCommit":{"message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[Flaky #70928] Unskip test (#166177)](#166177) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-09-13T07:06:05Z","message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Security","technical debt","release_note:skip","backport:all-open","v8.11.0"],"number":166177,"url":"https://github.com/elastic/kibana/pull/166177","mergeCommit":{"message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166177","number":166177,"mergeCommit":{"message":"[Flaky #70928] Unskip test (#166177)","sha":"df08786c98cd12e020934126e8d6af3f460d0a34"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #70928
Unskipping showed that the first check (
isChromeHidden()) is no longer true.TBH, the test seems fairly simple. But I think it still tests the feature: it opens an embedded view with a logged-in user.
🟢 Flaky test runner (400x): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3079
For maintainers