You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For tabbed Logs Explorer / Discover (in serverless), the choice of the tab should be remembered per user and made automatically the next time the user clicks the “Discover” nav item. Initially, the Logs Explorer tab will be rendered.
Acceptance Criteria
The user's last clicked tab should be stored in local storage.
When navigating using the navigation item the value should be read from local storage, and the correct tab used.
The Logs Explorer tab should be used as the default.
Technical concerns and approach
There is no direct platform functionality to assist here.
The navigationTree that renders the navigation items only accepts a string (technically an app id or deep link id) for link, therefore we cannot perform any logic (reading local storage etc) for the navigation tree itself, href can also only be a string. There is an onClick prop which takes precedence, but we wouldn't have access here to the resources we need (locators, local storage utils etc).
Therefore I would propose that we add a new route (either under Discover or Logs Explorer) which acts purely as a redirection route. It would perform the logic we need, and then navigate to the correct tab. This then gives us a link that we can actually provide to the navigation tree. We should just be careful of redundant history entries.
The text was updated successfully, but these errors were encountered:
Summary
For tabbed Logs Explorer / Discover (in serverless), the choice of the tab should be remembered per user and made automatically the next time the user clicks the “Discover” nav item. Initially, the Logs Explorer tab will be rendered.
Acceptance Criteria
Technical concerns and approach
There is no direct platform functionality to assist here.
The
navigationTree
that renders the navigation items only accepts astring
(technically an app id or deep link id) forlink
, therefore we cannot perform any logic (reading local storage etc) for the navigation tree itself,href
can also only be astring
. There is anonClick
prop which takes precedence, but we wouldn't have access here to the resources we need (locators, local storage utils etc).Therefore I would propose that we add a new route (either under Discover or Logs Explorer) which acts purely as a redirection route. It would perform the logic we need, and then navigate to the correct tab. This then gives us a
link
that we can actually provide to the navigation tree. We should just be careful of redundant history entries.The text was updated successfully, but these errors were encountered: