Addressing feedback

Author: jonathan-buttner

x-pack/plugins/security_solution/public/app/home/index.tsx

@@ -60,6 +60,10 @@ const HomePageComponent: React.FC<HomePageProps> = ({ children }) => {
 
   const { browserFields, indexPattern, indicesExist } = useSourcererScope();
   // side effect: this will attempt to upgrade the endpoint package if it is not up to date
+  // this will run when a user navigates to the Security Solution app and when they navigate between
+  // tabs in the app. This is useful for keeping the endpoint package as up to date as possible until
+  // a background task solution can be built on the server side. Once a background task solution is available we
+  // can remove this.
   useUpgradeEndpointPackage();
 
   return (

x-pack/plugins/security_solution/public/common/hooks/endpoint/upgrade.ts

@@ -57,7 +57,7 @@ export const useUpgradeEndpointPackage = () => {
     const abortController = new AbortController();
 
     // cancel any ongoing requests
-    const cleanup = () => {
+    const abortRequests = () => {
       abortController.abort();
     };
 
@@ -73,18 +73,22 @@ export const useUpgradeEndpointPackage = () => {
 
           // if we're not a privileged user then return and don't try to check the status of the endpoint package
           if (!hasPermissions) {
-            return cleanup;
+            return abortRequests;
           }
 
           // ignore the response for now since we aren't notifying the user
           await sendUpgradeEndpointPackage(context.services.http, { signal });
         } catch (error) {
           // Ignore Errors, since this should not hinder the user's ability to use the UI
-          // eslint-disable-next-line no-console
-          console.error(error);
+
+          // ignore the error that occurs from aborting a request
+          if (!abortController.signal.aborted) {
+            // eslint-disable-next-line no-console
+            console.error(error);
+          }
         }
 
-        return cleanup;
+        return abortRequests;
       })();
     }
   }, [ingestEnabled, context.services.http]);