Skip to content

Commit fddf019

Browse files
author
sulemanof
committed
Use common no data message
1 parent d02577f commit fddf019

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/plugins/vis_type_tagcloud/public/tag_cloud_type.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,5 +120,4 @@ export const tagCloudVisTypeDefinition = {
120120
},
121121
]),
122122
},
123-
useCustomNoDataScreen: true,
124123
};

src/plugins/vis_type_tagcloud/public/tag_cloud_vis_renderer.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import React, { lazy, Suspense } from 'react';
2121
import { render, unmountComponentAtNode } from 'react-dom';
2222
import { EuiLoadingSpinner } from '@elastic/eui';
23+
import { get } from 'lodash';
2324

2425
import { VisualizationContainer } from '../../visualizations/public';
2526
import { ExpressionRenderDefinition } from '../../expressions/common/expression_renderers';
@@ -41,7 +42,7 @@ export const getTagCloudVisRenderer: (
4142
});
4243

4344
render(
44-
<VisualizationContainer>
45+
<VisualizationContainer showNoResults={config.visData?.rows?.length === 0}>
4546
<Suspense fallback={<EuiLoadingSpinner />}>
4647
<TagCloudChart
4748
{...config}

src/plugins/visualizations/public/components/visualization_container.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,19 @@
1818
*/
1919

2020
import React, { ReactNode } from 'react';
21+
import { VisualizationNoResults } from './visualization_noresults';
2122

2223
interface VisualizationContainerProps {
2324
className?: string;
2425
children: ReactNode;
26+
showNoResults?: boolean;
2527
}
2628

27-
export const VisualizationContainer = (props: VisualizationContainerProps) => {
28-
const classes = `visualization ${props.className}`;
29-
return <div className={classes}>{props.children}</div>;
29+
export const VisualizationContainer = ({
30+
className = '',
31+
children,
32+
showNoResults = false,
33+
}: VisualizationContainerProps) => {
34+
const classes = `visualization ${className}`;
35+
return <div className={classes}>{showNoResults ? <VisualizationNoResults /> : children}</div>;
3036
};

0 commit comments

Comments
 (0)