Review changes

Author: ThomThomson

src/plugins/dashboard/public/application/actions/library_notification_action.tsx

@@ -79,7 +79,6 @@ export class LibraryNotificationAction implements ActionByType<typeof ACTION_LIB
 
   public isCompatible = async ({ embeddable }: LibraryNotificationActionContext) => {
     return (
-      embeddable.getRoot() &&
       embeddable.getRoot().isContainer &&
       embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
       isReferenceOrValueEmbeddable(embeddable) &&

src/plugins/dashboard/public/attribute_service/attribute_service.tsx

@@ -156,7 +156,7 @@ export class AttributeService<
   };
 
   public getExplicitInputFromEmbeddable(embeddable: IEmbeddable): ValType | RefType {
-    return ((embeddable.getRoot() as Container)?.getInput()?.panels?.[embeddable.id]
+    return ((embeddable.getRoot() as Container).getInput()?.panels?.[embeddable.id]
       ?.explicitInput ?? embeddable.getInput()) as ValType | RefType;
   }
 

x-pack/plugins/lens/public/editor_frame_service/embeddable/embeddable.tsx

@@ -136,7 +136,7 @@ export class Embeddable
     };
     const expression = await this.deps.documentToExpression(this.savedVis);
     this.expression = expression ? this.deps.toExpressionString(expression) : null;
-    this.initializeOutput();
+    await this.initializeOutput();
     this.isInitialized = true;
     if (this.domNode) {
       this.render(this.domNode);
@@ -257,12 +257,9 @@ export class Embeddable
           // to show.
           return null;
         }
-      });
-    const indexPatterns = (
-      await Promise.all(promises)
-    ).filter((indexPattern: IndexPattern | null): indexPattern is IndexPattern =>
-      Boolean(indexPattern)
-    );
+      })
+      .filter((promise): promise is Promise<IndexPattern> => Boolean(promise));
+    const indexPatterns = await Promise.all(promises);
     // passing edit url and index patterns to the output of this embeddable for
     // the container to pick them up and use them to configure filter bar and
     // config dropdown correctly.