Address PR comments

Author: Esteban Beltran

x-pack/plugins/security_solution/public/management/pages/event_filters/store/middleware.ts

@@ -231,7 +231,7 @@ const refreshListDataIfNeeded: MiddlewareActionHandler = async (store, eventFilt
     dispatch({
       type: 'eventFiltersListPageDataChanged',
       payload: {
-        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored
+        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored (#830)
         type: 'LoadingResourceState',
         previousState: getCurrentListPageDataState(state),
       },

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/store/middleware.test.ts

@@ -5,7 +5,10 @@
  * 2.0.
  */
 
-import { CreateExceptionListItemSchema } from '@kbn/securitysolution-io-ts-list-types';
+import {
+  CreateExceptionListItemSchema,
+  UpdateEndpointListItemSchema,
+} from '@kbn/securitysolution-io-ts-list-types';
 import { applyMiddleware, createStore, Store } from 'redux';
 import { coreMock } from '../../../../../../../../src/core/public/mocks';
 import { getFoundExceptionListItemSchemaMock } from '../../../../../../lists/common/schemas/response/found_exception_list_item_schema.mock';
@@ -224,22 +227,23 @@ describe('Host isolation exceptions middleware', () => {
 
   describe('When updating an item from host isolation exceptions', () => {
     const fakeId = 'dc5d1d00-2766-11ec-981f-7f84cfc8764f';
-    const fakeException = {
-      ...createEmptyHostIsolationException(),
-      name: 'name edit me',
-      description: 'initial description',
-      id: fakeId,
-      item_id: fakeId,
-      entries: [
-        {
-          field: 'destination.ip',
-          operator: 'included',
-          type: 'match',
-          value: '10.0.0.5',
-        },
-      ],
-    };
+    let fakeException: UpdateEndpointListItemSchema;
     beforeEach(() => {
+      fakeException = {
+        ...createEmptyHostIsolationException(),
+        name: 'name edit me',
+        description: 'initial description',
+        id: fakeId,
+        item_id: fakeId,
+        entries: [
+          {
+            field: 'destination.ip',
+            operator: 'included',
+            type: 'match',
+            value: '10.0.0.5',
+          },
+        ],
+      };
       getOneHostIsolationExceptionItemMock.mockReset();
       getOneHostIsolationExceptionItemMock.mockImplementation(async () => {
         return fakeException;

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/store/middleware.ts

@@ -79,7 +79,7 @@ async function createHostIsolationException(
   dispatch({
     type: 'hostIsolationExceptionsFormStateChanged',
     payload: {
-      // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored
+      // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored (#830)
       type: 'LoadingResourceState',
       previousState: entry,
     },
@@ -122,7 +122,7 @@ async function loadHostIsolationExceptionsList(
     dispatch({
       type: 'hostIsolationExceptionsPageDataChanged',
       payload: {
-        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored
+        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored (#830)
         type: 'LoadingResourceState',
         previousState: getCurrentListPageDataState(store.getState()),
       },
@@ -164,7 +164,7 @@ async function deleteHostIsolationExceptionsItem(
     dispatch({
       type: 'hostIsolationExceptionsDeleteStatusChanged',
       payload: {
-        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored
+        // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored (#830)
         type: 'LoadingResourceState',
         previousState: store.getState().deletion.status,
       },
@@ -221,7 +221,7 @@ async function updateHostIsolationExceptionsItem(
   try {
     const entry = transformOutput(exception as UpdateExceptionListItemSchema);
     // Clean unnecessary fields for update action
-    [
+    const fieldsToRemove: Array<keyof ExceptionListItemSchema> = [
       'created_at',
       'created_by',
       'created_at',
@@ -230,7 +230,9 @@ async function updateHostIsolationExceptionsItem(
       'tie_breaker_id',
       'updated_at',
       'updated_by',
-    ].forEach((field) => {
+    ];
+
+    fieldsToRemove.forEach((field) => {
       delete entry[field as keyof UpdateExceptionListItemSchema];
     });
     const response: ExceptionListItemSchema = await updateOneHostIsolationExceptionItem(

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/components/form_flyout.tsx

@@ -103,7 +103,6 @@ export const HostIsolationExceptionsFormFlyout: React.FC<{}> = memo(() => {
         setException(exceptionToEdit);
       }
     }
-    // initialize an empty exception to create
   }, [dispatch, exception, exceptionToEdit, location.id, location.show, onCancel]);
 
   // handle creation and edit success

x-pack/plugins/security_solution/public/management/pages/trusted_apps/store/middleware.ts

@@ -412,7 +412,7 @@ const fetchEditTrustedAppIfNeeded = async (
         dispatch({
           type: 'trustedAppCreationEditItemStateChanged',
           payload: {
-            // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored
+            // @ts-expect-error-next-line will be fixed with when AsyncResourceState is refactored (#830)
             type: 'LoadingResourceState',
             previousState: editItemState(currentState)!,
           },