From f8c4b9ad7b0218986ed5fbeb914700d9c8703e32 Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Fri, 18 Oct 2024 10:29:55 +0200 Subject: [PATCH] [Discover] Unskip esql view tests (#196677) - Closes https://github.com/elastic/kibana/issues/194305 - Closes https://github.com/elastic/kibana/issues/194425 - Closes https://github.com/elastic/kibana/issues/194482 --- test/functional/apps/discover/esql/_esql_view.ts | 2 ++ .../test_suites/common/discover/esql/_esql_view.ts | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/test/functional/apps/discover/esql/_esql_view.ts b/test/functional/apps/discover/esql/_esql_view.ts index 760827816db964..31e89ac42f3ea6 100644 --- a/test/functional/apps/discover/esql/_esql_view.ts +++ b/test/functional/apps/discover/esql/_esql_view.ts @@ -268,6 +268,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('should not show switch modal when switching to a data view while a saved search is open', async () => { await discover.selectTextBaseLang(); + await header.waitUntilLoadingHasFinished(); + await discover.waitUntilSearchingHasFinished(); const testQuery = 'from logstash-* | limit 100 | drop @timestamp'; await monacoEditor.setCodeEditorValue(testQuery); await testSubjects.click('querySubmitButton'); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts b/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts index 89edce106f64e7..c82882623b1779 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts @@ -35,8 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { defaultIndex: 'logstash-*', }; - // Failing: See https://github.com/elastic/kibana/issues/194305 - describe.skip('discover esql view', function () { + describe('discover esql view', function () { // see details: https://github.com/elastic/kibana/issues/188816 this.tags(['failsOnMKI']); @@ -275,6 +274,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('should not show switch modal when switching to a data view while a saved search is open', async () => { await PageObjects.discover.selectTextBaseLang(); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.discover.waitUntilSearchingHasFinished(); const testQuery = 'from logstash-* | limit 100 | drop @timestamp'; await monacoEditor.setCodeEditorValue(testQuery); await testSubjects.click('querySubmitButton');