From f6b7df3d6ef1501d36546ff85bd10b954b95ddad Mon Sep 17 00:00:00 2001
From: Aleh Zasypkin <aleh.zasypkin@elastic.co>
Date: Thu, 21 Dec 2023 15:48:53 +0100
Subject: [PATCH] Unskip `Session Concurrent Limit cleanup` tests. (#173828)

## Summary

Unskip `Session Concurrent Limit cleanup` tests.

__Flaky Test Runner#1 (no changes, only unskipped tests):__
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4666
(x100 - :red_circle: 1 out of 100)
__Flaky Test Runner#2 (added additional `retry`):__
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4667
(x200 - all :green_circle:)

__Fixes: https://github.com/elastic/kibana/issues/149091__
---
 .../tests/session_concurrent_limit/cleanup.ts | 33 ++++++++++++++-----
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/x-pack/test/security_api_integration/tests/session_concurrent_limit/cleanup.ts b/x-pack/test/security_api_integration/tests/session_concurrent_limit/cleanup.ts
index 45d3bfc5b12eae..32f5351b4e4609 100644
--- a/x-pack/test/security_api_integration/tests/session_concurrent_limit/cleanup.ts
+++ b/x-pack/test/security_api_integration/tests/session_concurrent_limit/cleanup.ts
@@ -150,8 +150,7 @@ export default function ({ getService }: FtrProviderContext) {
     });
   }
 
-  // Failing: See https://github.com/elastic/kibana/issues/149091
-  describe.skip('Session Concurrent Limit cleanup', () => {
+  describe('Session Concurrent Limit cleanup', () => {
     before(async () => {
       await security.user.create('anonymous_user', {
         password: 'changeme',
@@ -181,7 +180,10 @@ export default function ({ getService }: FtrProviderContext) {
       await setTimeoutAsync(500);
       const basicSessionCookieThree = await loginWithBasic(testUser);
 
-      expect(await getNumberOfSessionDocuments()).to.be(3);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(3);
+      });
 
       // Poke the background task to run
       await runCleanupTaskSoon();
@@ -210,7 +212,10 @@ export default function ({ getService }: FtrProviderContext) {
       const basicSessionCookieThree = await loginWithBasic(testUser);
       const samlSessionCookieThree = await loginWithSAML();
 
-      expect(await getNumberOfSessionDocuments()).to.be(6);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(6);
+      });
 
       // Poke the background task to run
       await runCleanupTaskSoon();
@@ -243,7 +248,10 @@ export default function ({ getService }: FtrProviderContext) {
       const basicSessionCookieThree = await loginWithBasic(testUser);
       const samlSessionCookieThree = await loginWithSAML();
 
-      expect(await getNumberOfSessionDocuments()).to.be(6);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(6);
+      });
 
       // Remove `createdAt` field from the most recent sessions to emulate legacy sessions.
       // 1. Get the latest session for every unique credentials.
@@ -305,7 +313,10 @@ export default function ({ getService }: FtrProviderContext) {
       await setTimeoutAsync(500);
       const basicSessionCookieTwo = await loginWithBasic(testUser);
 
-      expect(await getNumberOfSessionDocuments()).to.be(2);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(2);
+      });
 
       // Poke the background task to run
       await runCleanupTaskSoon();
@@ -328,7 +339,10 @@ export default function ({ getService }: FtrProviderContext) {
       const anonymousSessionCookieTwo = await loginWithAnonymous();
       const anonymousSessionCookieThree = await loginWithAnonymous();
 
-      expect(await getNumberOfSessionDocuments()).to.be(3);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(3);
+      });
 
       // Poke the background task to run
       await runCleanupTaskSoon();
@@ -357,7 +371,10 @@ export default function ({ getService }: FtrProviderContext) {
       const unauthenticatedSessionTwo = await startSAMLHandshake();
       const unauthenticatedSessionThree = await startSAMLHandshake();
 
-      expect(await getNumberOfSessionDocuments()).to.be(3);
+      log.debug('Waiting for all sessions to be persisted...');
+      await retry.tryForTime(20000, async () => {
+        expect(await getNumberOfSessionDocuments()).to.be(3);
+      });
 
       // Poke the background task to run
       await runCleanupTaskSoon();