Skip to content

Commit ef5287f

Browse files
XavierMangoraycpatrykkopycinski
authored
[SECURITY SOLUTIONS] Bring Async Search Back (#82650)
* bring async search back to the security solutions * remove id for timeline details searchStrategy * fix events count * fix total count * update units * update integration tests Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
1 parent 3c99839 commit ef5287f

File tree

37 files changed

+46
-115
lines changed

37 files changed

+46
-115
lines changed

x-pack/plugins/security_solution/public/common/containers/events/last_event_time/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ import {
2525
import * as i18n from './translations';
2626
import { DocValueFields } from '../../../../../common/search_strategy';
2727

28-
const ID = 'timelineEventsLastEventTimeQuery';
29-
3028
export interface UseTimelineLastEventTimeArgs {
3129
lastSeen: string | null;
3230
refetch: inputsModel.Refetch;
@@ -56,7 +54,6 @@ export const useTimelineLastEventTime = ({
5654
defaultIndex: indexNames,
5755
docValueFields,
5856
factoryQueryType: TimelineEventsQueries.lastEventTime,
59-
id: ID,
6057
indexKey,
6158
details,
6259
});

x-pack/plugins/security_solution/public/common/containers/matrix_histogram/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ export interface UseMatrixHistogramArgs {
4545
}>;
4646
}
4747

48-
const ID = 'matrixHistogramQuery';
49-
5048
export const useMatrixHistogram = ({
5149
endDate,
5250
errorMessage,
@@ -73,7 +71,6 @@ export const useMatrixHistogram = ({
7371
factoryQueryType: MatrixHistogramQuery,
7472
filterQuery: createFilter(filterQuery),
7573
histogramType,
76-
id: ID,
7774
timerange: {
7875
interval: '12h',
7976
from: startDate,

x-pack/plugins/security_solution/public/hosts/containers/authentications/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ export const useAuthentications = ({
8888
docValueFields: docValueFields ?? [],
8989
factoryQueryType: HostsQueries.authentications,
9090
filterQuery: createFilter(filterQuery),
91-
id: ID,
9291
pagination: generateTablePaginationOptions(activePage, limit),
9392
timerange: {
9493
interval: '12h',
@@ -203,7 +202,6 @@ export const useAuthentications = ({
203202
docValueFields: docValueFields ?? [],
204203
factoryQueryType: HostsQueries.authentications,
205204
filterQuery: createFilter(filterQuery),
206-
id: ID,
207205
pagination: generateTablePaginationOptions(activePage, limit),
208206
timerange: {
209207
interval: '12h',

x-pack/plugins/security_solution/public/hosts/containers/hosts/details/_index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export const useHostDetails = ({
6565
? {
6666
defaultIndex: indexNames,
6767
hostName,
68-
id,
6968
factoryQueryType: HostsQueries.details,
7069
timerange: {
7170
interval: '12h',
@@ -79,7 +78,7 @@ export const useHostDetails = ({
7978
const [hostDetailsResponse, setHostDetailsResponse] = useState<HostDetailsArgs>({
8079
endDate,
8180
hostDetails: {},
82-
id: ID,
81+
id,
8382
inspect: {
8483
dsl: [],
8584
response: [],
@@ -154,7 +153,6 @@ export const useHostDetails = ({
154153
defaultIndex: indexNames,
155154
factoryQueryType: HostsQueries.details,
156155
hostName,
157-
id: ID,
158156
timerange: {
159157
interval: '12h',
160158
from: startDate,

x-pack/plugins/security_solution/public/hosts/containers/hosts/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ export const useAllHost = ({
8383
docValueFields: docValueFields ?? [],
8484
factoryQueryType: HostsQueries.hosts,
8585
filterQuery: createFilter(filterQuery),
86-
id: ID,
8786
pagination: generateTablePaginationOptions(activePage, limit),
8887
timerange: {
8988
interval: '12h',
@@ -200,7 +199,6 @@ export const useAllHost = ({
200199
docValueFields: docValueFields ?? [],
201200
factoryQueryType: HostsQueries.hosts,
202201
filterQuery: createFilter(filterQuery),
203-
id: ID,
204202
pagination: generateTablePaginationOptions(activePage, limit),
205203
timerange: {
206204
interval: '12h',

x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/authentications/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ export const useHostsKpiAuthentications = ({
6161
defaultIndex: indexNames,
6262
factoryQueryType: HostsKpiQueries.kpiAuthentications,
6363
filterQuery: createFilter(filterQuery),
64-
id: ID,
6564
timerange: {
6665
interval: '12h',
6766
from: startDate,
@@ -159,7 +158,6 @@ export const useHostsKpiAuthentications = ({
159158
defaultIndex: indexNames,
160159
factoryQueryType: HostsKpiQueries.kpiAuthentications,
161160
filterQuery: createFilter(filterQuery),
162-
id: ID,
163161
timerange: {
164162
interval: '12h',
165163
from: startDate,

x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/hosts/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export const useHostsKpiHosts = ({
6060
defaultIndex: indexNames,
6161
factoryQueryType: HostsKpiQueries.kpiHosts,
6262
filterQuery: createFilter(filterQuery),
63-
id: ID,
6463
timerange: {
6564
interval: '12h',
6665
from: startDate,
@@ -149,7 +148,6 @@ export const useHostsKpiHosts = ({
149148
defaultIndex: indexNames,
150149
factoryQueryType: HostsKpiQueries.kpiHosts,
151150
filterQuery: createFilter(filterQuery),
152-
id: ID,
153151
timerange: {
154152
interval: '12h',
155153
from: startDate,

x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/unique_ips/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ export const useHostsKpiUniqueIps = ({
6161
defaultIndex: indexNames,
6262
factoryQueryType: HostsKpiQueries.kpiUniqueIps,
6363
filterQuery: createFilter(filterQuery),
64-
id: ID,
6564
timerange: {
6665
interval: '12h',
6766
from: startDate,
@@ -156,7 +155,6 @@ export const useHostsKpiUniqueIps = ({
156155
defaultIndex: indexNames,
157156
factoryQueryType: HostsKpiQueries.kpiUniqueIps,
158157
filterQuery: createFilter(filterQuery),
159-
id: ID,
160158
timerange: {
161159
interval: '12h',
162160
from: startDate,

x-pack/plugins/security_solution/public/hosts/containers/uncommon_processes/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ export const useUncommonProcesses = ({
8585
docValueFields: docValueFields ?? [],
8686
factoryQueryType: HostsQueries.uncommonProcesses,
8787
filterQuery: createFilter(filterQuery),
88-
id: ID,
8988
pagination: generateTablePaginationOptions(activePage, limit),
9089
timerange: {
9190
interval: '12h',
@@ -204,7 +203,6 @@ export const useUncommonProcesses = ({
204203
docValueFields: docValueFields ?? [],
205204
factoryQueryType: HostsQueries.uncommonProcesses,
206205
filterQuery: createFilter(filterQuery),
207-
id: ID,
208206
pagination: generateTablePaginationOptions(activePage, limit),
209207
timerange: {
210208
interval: '12h',

x-pack/plugins/security_solution/public/network/containers/details/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export const useNetworkDetails = ({
6969
docValueFields: docValueFields ?? [],
7070
factoryQueryType: NetworkQueries.details,
7171
filterQuery: createFilter(filterQuery),
72-
id,
7372
ip,
7473
}
7574
: null
@@ -153,7 +152,6 @@ export const useNetworkDetails = ({
153152
docValueFields: docValueFields ?? [],
154153
factoryQueryType: NetworkQueries.details,
155154
filterQuery: createFilter(filterQuery),
156-
id,
157155
ip,
158156
};
159157
if (!skip && !deepEqual(prevRequest, myRequest)) {

0 commit comments

Comments
 (0)