Skip to content

Commit eef1fc0

Browse files
committed
feat: 🎸 address review comments
1 parent 1b2d995 commit eef1fc0

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

‎src/dev/storybook/commands/clean.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@
1818
*/
1919

2020
import { ToolingLog } from '@kbn/dev-utils';
21+
import { REPO_ROOT } from '@kbn/dev-utils';
2122
import { join } from 'path';
2223
import del from 'del';
2324

24-
export const clean = async ({ log, rootDir }: { log: ToolingLog; rootDir: string }) => {
25+
export const clean = async ({ log }: { log: ToolingLog }) => {
2526
log.info('Cleaning Storybook build folder');
2627

27-
const dir = join(rootDir, 'built_assets', 'storybook');
28+
const dir = join(REPO_ROOT, 'built_assets', 'storybook');
2829
log.info('Deleting folder:', dir);
2930
await del([join(dir, '*')]);
3031
await del([dir]);

‎src/dev/storybook/run_storybook_cli.ts‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@
1919

2020
import { join } from 'path';
2121
import { run, createFlagError } from '@kbn/dev-utils';
22+
import { REPO_ROOT } from '@kbn/dev-utils';
2223
import { storybookAliases } from './aliases';
2324
import { clean } from './commands/clean';
2425

25-
const rootDir = join(__dirname, '..', '..', '..');
26-
2726
run(
2827
async params => {
2928
const { flags, log } = params;
@@ -32,11 +31,11 @@ run(
3231
} = flags;
3332

3433
if (flags.verbose) {
35-
log.info('Flags:', flags);
34+
log.verbose('Flags:', flags);
3635
}
3736

3837
if (flags.clean) {
39-
await clean({ log, rootDir });
38+
await clean({ log });
4039
return;
4140
}
4241

@@ -49,9 +48,9 @@ run(
4948
}
5049

5150
const relative = (storybookAliases as any)[alias];
52-
const absolute = join(rootDir, relative);
51+
const absolute = join(REPO_ROOT, relative);
5352

54-
log.info('Loading Storybook:', absolute);
53+
log.verbose('Loading Storybook:', absolute);
5554
process.chdir(join(absolute, '..', '..'));
5655
require(absolute);
5756
},

‎x-pack/legacy/plugins/canvas/public/components/color_manager/color_manager.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const ColorManager: FunctionComponent<Props> = ({
7474
<EuiFieldText
7575
value={value}
7676
isInvalid={!validColor && value.length > 0}
77-
placeholder={'strings.getCodePlaceholder()'}
77+
placeholder={strings.getCodePlaceholder()}
7878
onChange={e => onChange(e.target.value)}
7979
/>
8080
</EuiFlexItem>

0 commit comments

Comments
 (0)