Skip to content

Commit ee81b5f

Browse files
authored
[Alerting UI] Fix console error when setting connector params (#83333)
* Fixing console errors * Setting defaults for undefined inputs in text area/field with message variables * Cleanup * Cleanup * Fixing pagerduty timestamp validation * Fixing test * Pagerduty params * Reverting unnecessary changes
1 parent 0a7f462 commit ee81b5f

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

x-pack/plugins/triggers_actions_ui/public/application/components/text_area_with_message_variables.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const TextAreaWithMessageVariables: React.FunctionComponent<Props> = ({
6363
fullWidth
6464
isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
6565
name={paramsProperty}
66-
value={inputTargetValue}
66+
value={inputTargetValue || ''}
6767
data-test-subj={`${paramsProperty}TextArea`}
6868
onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => onChangeWithMessageVariable(e)}
6969
onFocus={(e: React.FocusEvent<HTMLTextAreaElement>) => {

x-pack/plugins/triggers_actions_ui/public/application/components/text_field_with_message_variables.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export const TextFieldWithMessageVariables: React.FunctionComponent<Props> = ({
5050
id={`${paramsProperty}Id`}
5151
isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
5252
data-test-subj={`${paramsProperty}Input`}
53-
value={inputTargetValue}
53+
value={inputTargetValue || ''}
5454
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChangeWithMessageVariable(e)}
5555
onFocus={(e: React.FocusEvent<HTMLInputElement>) => {
5656
setCurrentTextElement(e.target);

x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,8 @@ export const ConnectorAddFlyout = ({
7272
const [isSaving, setIsSaving] = useState<boolean>(false);
7373

7474
const closeFlyout = useCallback(() => {
75-
setActionType(undefined);
76-
setConnector(initialConnector);
7775
onClose();
78-
}, [onClose, initialConnector]);
76+
}, [onClose]);
7977

8078
const canSave = hasSaveActionsCapability(capabilities);
8179

0 commit comments

Comments
 (0)