Skip to content

Commit ec2e075

Browse files
committed
improve code ownership
1 parent 28fcebc commit ec2e075

File tree

3 files changed

+48
-26
lines changed

3 files changed

+48
-26
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
/x-pack/plugins/apm/public/components/app/RumDashboard @elastic/uptime
7171
/x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
7272
/x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
73+
/x-pack/plugins/apm/server/routes/create_ux_api.ts @elastic/uptime
7374
/x-pack/plugins/apm/server/projections/rum_page_load_transactions.ts @elastic/uptime
7475

7576
# Beats

x-pack/plugins/apm/server/routes/create_apm_api.ts

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ import {
5858
transactionsLocalFiltersRoute,
5959
serviceNodesLocalFiltersRoute,
6060
uiFiltersEnvironmentsRoute,
61-
rumOverviewLocalFiltersRoute,
6261
} from './ui_filters';
6362
import { createApi } from './create_api';
6463
import { serviceMapRoute, serviceMapServiceNodeRoute } from './service_map';
@@ -69,18 +68,6 @@ import {
6968
listCustomLinksRoute,
7069
customLinkTransactionRoute,
7170
} from './settings/custom_link';
72-
import {
73-
rumClientMetricsRoute,
74-
rumPageViewsTrendRoute,
75-
rumPageLoadDistributionRoute,
76-
rumPageLoadDistBreakdownRoute,
77-
rumServicesRoute,
78-
rumVisitorsBreakdownRoute,
79-
rumWebCoreVitals,
80-
rumJSErrors,
81-
rumUrlSearch,
82-
rumLongTaskMetrics,
83-
} from './rum_client';
8471
import {
8572
observabilityOverviewHasDataRoute,
8673
observabilityOverviewRoute,
@@ -90,6 +77,7 @@ import {
9077
createAnomalyDetectionJobsRoute,
9178
anomalyDetectionEnvironmentsRoute,
9279
} from './settings/anomaly_detection';
80+
import { createUXAPIRoutes } from './create_ux_api';
9381

9482
const createApmApi = () => {
9583
const api = createApi()
@@ -166,19 +154,6 @@ const createApmApi = () => {
166154
.add(listCustomLinksRoute)
167155
.add(customLinkTransactionRoute)
168156

169-
// Rum Overview
170-
.add(rumOverviewLocalFiltersRoute)
171-
.add(rumPageViewsTrendRoute)
172-
.add(rumPageLoadDistributionRoute)
173-
.add(rumPageLoadDistBreakdownRoute)
174-
.add(rumClientMetricsRoute)
175-
.add(rumServicesRoute)
176-
.add(rumVisitorsBreakdownRoute)
177-
.add(rumWebCoreVitals)
178-
.add(rumJSErrors)
179-
.add(rumUrlSearch)
180-
.add(rumLongTaskMetrics)
181-
182157
// Observability dashboard
183158
.add(observabilityOverviewHasDataRoute)
184159
.add(observabilityOverviewRoute)
@@ -188,6 +163,9 @@ const createApmApi = () => {
188163
.add(createAnomalyDetectionJobsRoute)
189164
.add(anomalyDetectionEnvironmentsRoute);
190165

166+
// User Experience app api routes
167+
createUXAPIRoutes(api);
168+
191169
return api;
192170
};
193171

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
/*
2+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
3+
* or more contributor license agreements. Licensed under the Elastic License;
4+
* you may not use this file except in compliance with the Elastic License.
5+
*/
6+
7+
/*
8+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
9+
* or more contributor license agreements. Licensed under the Elastic License;
10+
* you may not use this file except in compliance with the Elastic License.
11+
*/
12+
13+
import { rumOverviewLocalFiltersRoute } from './ui_filters';
14+
15+
import { ServerAPI } from './typings';
16+
import {
17+
rumClientMetricsRoute,
18+
rumJSErrors,
19+
rumLongTaskMetrics,
20+
rumPageLoadDistBreakdownRoute,
21+
rumPageLoadDistributionRoute,
22+
rumPageViewsTrendRoute,
23+
rumServicesRoute,
24+
rumUrlSearch,
25+
rumVisitorsBreakdownRoute,
26+
rumWebCoreVitals,
27+
} from './rum_client';
28+
29+
export const createUXAPIRoutes = (api: ServerAPI<{}>) => {
30+
api
31+
// Rum Overview
32+
.add(rumOverviewLocalFiltersRoute)
33+
.add(rumPageViewsTrendRoute)
34+
.add(rumPageLoadDistributionRoute)
35+
.add(rumPageLoadDistBreakdownRoute)
36+
.add(rumClientMetricsRoute)
37+
.add(rumServicesRoute)
38+
.add(rumVisitorsBreakdownRoute)
39+
.add(rumWebCoreVitals)
40+
.add(rumJSErrors)
41+
.add(rumUrlSearch)
42+
.add(rumLongTaskMetrics);
43+
};

0 commit comments

Comments
 (0)