Fix action group ternary and jest test failure

Author: Zacqary

x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx

@@ -520,7 +520,7 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = (props) => {
       threshold={threshold}
       updateComparator={updateComparator}
       updateThreshold={updateThreshold}
-      errors={errors.critical as IErrorObject}
+      errors={(errors.critical as IErrorObject) ?? {}}
       metric={metric}
     />
   );
@@ -531,7 +531,7 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = (props) => {
       threshold={warningThreshold}
       updateComparator={updateWarningComparator}
       updateThreshold={updateWarningThreshold}
-      errors={errors.warning as IErrorObject}
+      errors={(errors.warning as IErrorObject) ?? {}}
       metric={metric}
     />
   );

x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx

@@ -186,7 +186,7 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = (props) => {
       threshold={threshold}
       updateComparator={updateComparator}
       updateThreshold={updateThreshold}
-      errors={errors.critical as IErrorObject}
+      errors={(errors.critical as IErrorObject) ?? {}}
       isMetricPct={isMetricPct}
     />
   );
@@ -197,7 +197,7 @@ export const ExpressionRow: React.FC<ExpressionRowProps> = (props) => {
       threshold={warningThreshold}
       updateComparator={updateWarningComparator}
       updateThreshold={updateWarningThreshold}
-      errors={errors.warning as IErrorObject}
+      errors={(errors.warning as IErrorObject) ?? {}}
       isMetricPct={isMetricPct}
     />
   );

x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts

@@ -136,7 +136,7 @@ export const createInventoryMetricThresholdExecutor = (libs: InfraBackendLibs) =
       const actionGroupId =
         nextState === AlertStates.OK
           ? RecoveredActionGroup.id
-          : AlertStates.WARNING
+          : nextState === AlertStates.WARNING
           ? WARNING_ACTIONS.id
           : FIRED_ACTIONS.id;
       alertInstance.scheduleActions(

x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts

@@ -114,7 +114,7 @@ export const createMetricThresholdExecutor = (
         const actionGroupId =
           nextState === AlertStates.OK
             ? RecoveredActionGroup.id
-            : AlertStates.WARNING
+            : nextState === AlertStates.WARNING
             ? WARNING_ACTIONS.id
             : FIRED_ACTIONS.id;
         alertInstance.scheduleActions(actionGroupId, {