[Maps] Support by value saved objects. (#82486) (#83091)

* [Maps] saved objects by value

* inject references when unwrapping

* clean up map embeddable initialize

* use attribute service to load savedMap

* clean up

* remove clear ui since each route has its own store instance

* save

* update for API changes

* pass input to stateTransfer

* remove map saved object loader

* remove unused store_operations

* add saved objects to recently accessed

* provide default description

* break originatingApp connection when not returnToOrigin

* clean up file structure

* clean up adding help menu

* use SavedMap in map_embeddable to remove dupicated load attributes code

* clean up

* restore imports

* clean up breadcrumbs to match lens

* fix check for duplicate title

* tslint

* make title map saved object attribute required

* fix jest tests

* fix logic for hasSaveAndReturnConfig to not show save and return button with new map and allowByValueEmbeddables disabled

* tslint

* fix functional test by triggering MapApp render after save

* rename map_app_container to map_page

* move MapApp and redux connector into folder

* review feedback

* use MAP_PATH constant

* update by reference saved object on save and return

* cleanup breadcrumbs and title

* properly handle deleted map saved objects

* tslint cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Author: nreese

x-pack/plugins/apm/public/components/app/RumDashboard/VisitorBreakdownMap/EmbeddedMap.tsx

@@ -77,6 +77,7 @@ export function EmbeddedMapComponent() {
   );
 
   const input: MapEmbeddableInput = {
+    attributes: { title: '' },
     id: uuid.v4(),
     filters: mapFilters,
     refreshConfig: {

x-pack/plugins/canvas/canvas_plugin_src/functions/external/saved_map.ts

@@ -83,6 +83,7 @@ export function savedMap(): ExpressionFunctionDefinition<
       return {
         type: EmbeddableExpressionType,
         input: {
+          attributes: { title: '' },
           id: args.id,
           filters: getQueryFilters(filters),
           timeRange: args.timerange || defaultTimeRange,

x-pack/plugins/canvas/canvas_plugin_src/renderers/embeddable/input_type_to_expression/map.test.ts

@@ -9,6 +9,7 @@ import { MapEmbeddableInput } from '../../../../../../plugins/maps/public/embedd
 import { fromExpression, Ast } from '@kbn/interpreter/common';
 
 const baseSavedMapInput = {
+  attributes: { title: '' },
   id: 'embeddableId',
   filters: [],
   isLayerTOCOpen: false,

x-pack/plugins/maps/common/i18n_getters.ts

@@ -15,6 +15,12 @@ export function getAppTitle() {
   });
 }
 
+export function getMapEmbeddableDisplayName() {
+  return i18n.translate('xpack.maps.embeddableDisplayName', {
+    defaultMessage: 'map',
+  });
+}
+
 export function getDataSourceLabel() {
   return i18n.translate('xpack.maps.source.dataSourceLabel', {
     defaultMessage: 'Data source',

x-pack/plugins/maps/common/map_saved_object_type.ts

@@ -8,7 +8,7 @@
 import { SavedObject } from '../../../../src/core/types/saved_objects';
 
 export type MapSavedObjectAttributes = {
-  title?: string;
+  title: string;
   description?: string;
   mapStateJSON?: string;
   layerListJSON?: string;

x-pack/plugins/maps/kibana.json

@@ -12,6 +12,7 @@
     "uiActions",
     "navigation",
     "visualizations",
+    "dashboard",
     "embeddable",
     "mapsLegacy",
     "usageCollection",

x-pack/plugins/maps/public/actions/layer_actions.test.ts

@@ -8,6 +8,14 @@ import { addLayer } from './layer_actions';
 import { LayerDescriptor } from '../../common/descriptor_types';
 import { LICENSED_FEATURES } from '../licensed_features';
 
+jest.mock('../kibana_services', () => {
+  return {
+    getMapsCapabilities() {
+      return { save: true };
+    },
+  };
+});
+
 const getStoreMock = jest.fn();
 const dispatchMock = jest.fn();
 

x-pack/plugins/maps/public/actions/map_actions.test.js

@@ -10,6 +10,13 @@ jest.mock('./data_request_actions', () => {
     syncDataForAllLayers: () => {},
   };
 });
+jest.mock('../kibana_services', () => {
+  return {
+    getMapsCapabilities() {
+      return { save: true };
+    },
+  };
+});
 
 import { mapExtentChanged, setMouseCoordinates, setQuery } from './map_actions';
 

x-pack/plugins/maps/public/connected_components/toolbar_overlay/toolbar_overlay.test.tsx

@@ -7,6 +7,14 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
+jest.mock('../../kibana_services', () => {
+  return {
+    getMapsCapabilities() {
+      return { save: true };
+    },
+  };
+});
+
 // @ts-ignore
 import { ToolbarOverlay } from './toolbar_overlay';
 

x-pack/plugins/maps/public/connected_components/widget_overlay/layer_control/layer_toc/toc_entry/view.test.js

@@ -7,6 +7,14 @@
 import React from 'react';
 import { shallowWithIntl } from 'test_utils/enzyme_helpers';
 
+jest.mock('../../../../../kibana_services', () => {
+  return {
+    getMapsCapabilities() {
+      return { save: true };
+    },
+  };
+});
+
 import { TOCEntry } from './view';
 
 const LAYER_ID = '1';