Skip to content

Commit e0c969c

Browse files
committed
Remove superfluous comments
1 parent 411b0da commit e0c969c

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/create_rules_route.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ export const createRulesRoute = (
8989
// This will create the endpoint list if it does not exist yet
9090
await context.lists?.getExceptionListClient().createEndpointList();
9191

92-
/**
93-
* TODO: Remove this use of `as` by utilizing the proper type
94-
*/
9592
const createdRule = await alertsClient.create({
9693
data: internalRule,
9794
});

x-pack/plugins/security_solution/server/lib/detection_engine/signals/signal_rule_alert_type.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,6 @@ export const signalRulesAlertType = ({
8585
actionGroups: siemRuleActionGroups,
8686
defaultActionGroupId: 'default',
8787
validate: {
88-
/**
89-
* TODO: Fix typing inconsistancy between `RuleTypeParams` and `CreateRulesOptions`
90-
* Once that's done, you should be able to do:
91-
* ```
92-
* params: signalParamsSchema(),
93-
* ```
94-
*/
9588
params: {
9689
validate: (object: unknown): RuleParams => {
9790
const [validated, errors] = validateNonExact(object, ruleParams);

0 commit comments

Comments
 (0)