Skip to content

Commit e08f6a3

Browse files
authored
Always Show Embeddable Panel Header in Edit Mode (#79152)
* Always show header in edit mode
1 parent 46084cb commit e08f6a3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export function PanelHeader({
136136
}: PanelHeaderProps) {
137137
const viewDescription = getViewDescription(embeddable);
138138
const showTitle = !hidePanelTitle && (!isViewMode || title || viewDescription !== '');
139-
const showPanelBar = badges.length > 0 || notifications.length > 0 || showTitle;
139+
const showPanelBar = !isViewMode || badges.length > 0 || notifications.length > 0 || showTitle;
140140
const classes = classNames('embPanel__header', {
141141
// eslint-disable-next-line @typescript-eslint/naming-convention
142142
'embPanel__header--floater': !showPanelBar,

test/functional/apps/dashboard/dashboard_options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default function ({ getService, getPageObjects }) {
4444
await PageObjects.dashboard.checkHideTitle();
4545
await retry.try(async () => {
4646
const titles = await PageObjects.dashboard.getPanelTitles();
47-
expect(titles[0]).to.eql(undefined);
47+
expect(titles[0]).to.eql('');
4848
});
4949
});
5050

0 commit comments

Comments
 (0)