PR comments + test fixes

Author: joshdover

src/plugins/management/public/management_service.test.ts

@@ -29,9 +29,8 @@ test('Provides default sections', () => {
     () => {},
     coreMock.createSetup().getStartServices
   );
-  expect(service.getAllSections().length).toEqual(3);
+  expect(service.getAllSections().length).toEqual(2);
   expect(service.getSection('kibana')).not.toBeUndefined();
-  expect(service.getSection('logstash')).not.toBeUndefined();
   expect(service.getSection('elasticsearch')).not.toBeUndefined();
 });
 

x-pack/plugins/logstash/public/application/pipeline_edit_view.tsx

@@ -29,7 +29,7 @@ const usePipeline = (
   id?: string
 ) => {
   const mounted = usePromise();
-  const [pipeline, setPipeline] = useState<any | null>(null);
+  const [pipeline, setPipeline] = useState<any>(null);
 
   useLayoutEffect(() => {
     (async () => {

x-pack/plugins/logstash/public/plugin.ts

@@ -17,8 +17,6 @@ import {
 import { LicensingPluginSetup } from '../../licensing/public';
 import { ManagementSetup } from '../../../../src/plugins/management/public';
 
-// @ts-ignore
-import { PLUGIN } from '../common/constants';
 // @ts-ignore
 import { LogstashLicenseService } from './services';
 

x-pack/test/api_integration/apis/logstash/pipeline/delete.ts

@@ -20,7 +20,6 @@ export default function({ getService }: FtrProviderContext) {
         .send({
           id: 'fast_generator',
           description: 'foobar baz',
-          username: 'seger',
           pipeline: 'input { generator {} }\n\n output { stdout {} }',
         })
         .expect(204);

x-pack/test/api_integration/apis/logstash/pipeline/save.ts

@@ -28,7 +28,6 @@ export default function({ getService }: FtrProviderContext) {
         .send({
           id: 'fast_generator',
           description: 'foobar baz',
-          username: 'seger',
           pipeline: 'input { generator {} }\n\n output { stdout {} }',
         })
         .expect(204);