Skip to content

Commit d69222c

Browse files
committed
fixed typechecks
1 parent 23f5d87 commit d69222c

File tree

12 files changed

+4
-32
lines changed

12 files changed

+4
-32
lines changed

x-pack/examples/alerting_example/public/alert_types/always_firing.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import {
3232
export function getAlertType(): AlertTypeModel {
3333
return {
3434
id: 'example.always-firing',
35-
name: 'Always Fires',
3635
description: 'Alert when called',
3736
iconClass: 'bolt',
3837
documentationUrl: null,

x-pack/examples/alerting_example/public/alert_types/astros.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ function isValueInEnum(enumeratin: Record<string, any>, value: any): boolean {
4444
export function getAlertType(): AlertTypeModel {
4545
return {
4646
id: 'example.people-in-space',
47-
name: 'People Are In Space Right Now',
4847
description: 'Alert when people are in space right now',
4948
iconClass: 'globe',
5049
documentationUrl: null,

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ export function registerApmAlerts(
1414
) {
1515
alertTypeRegistry.register({
1616
id: AlertType.ErrorCount,
17-
name: i18n.translate('xpack.apm.alertTypes.errorCount', {
18-
defaultMessage: 'Error count threshold',
19-
}),
2017
description: i18n.translate('xpack.apm.alertTypes.errorCount.description', {
2118
defaultMessage:
2219
'Alert when the number of errors in a service exceeds a defined threshold.',
@@ -45,9 +42,6 @@ export function registerApmAlerts(
4542

4643
alertTypeRegistry.register({
4744
id: AlertType.TransactionDuration,
48-
name: i18n.translate('xpack.apm.alertTypes.transactionDuration', {
49-
defaultMessage: 'Transaction duration threshold',
50-
}),
5145
description: i18n.translate(
5246
'xpack.apm.alertTypes.transactionDuration.description',
5347
{
@@ -82,9 +76,6 @@ export function registerApmAlerts(
8276

8377
alertTypeRegistry.register({
8478
id: AlertType.TransactionErrorRate,
85-
name: i18n.translate('xpack.apm.alertTypes.transactionErrorRate', {
86-
defaultMessage: 'Transaction error rate threshold',
87-
}),
8879
description: i18n.translate(
8980
'xpack.apm.alertTypes.transactionErrorRate.description',
9081
{
@@ -119,9 +110,6 @@ export function registerApmAlerts(
119110

120111
alertTypeRegistry.register({
121112
id: AlertType.TransactionDurationAnomaly,
122-
name: i18n.translate('xpack.apm.alertTypes.transactionDurationAnomaly', {
123-
defaultMessage: 'Transaction duration anomaly',
124-
}),
125113
description: i18n.translate(
126114
'xpack.apm.alertTypes.transactionDurationAnomaly.description',
127115
{

x-pack/plugins/monitoring/public/alerts/alert_form.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ describe('alert_form', () => {
7171
const alertType = {
7272
id: 'alert-type',
7373
iconClass: 'test',
74-
name: 'test-alert',
7574
description: 'Testing',
7675
documentationUrl: 'https://...',
7776
validate: validationMethod,

x-pack/plugins/stack_alerts/server/alert_types/geo_containment/tests/alert_type.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('alertType', () => {
1414

1515
it('alert type creation structure is the expected value', async () => {
1616
expect(alertType.id).toBe('.geo-containment');
17-
expect(alertType.name).toBe('Geo tracking containment');
17+
expect(alertType.name).toBe('Tracking containment');
1818
expect(alertType.actionGroups).toEqual([
1919
{ id: 'Tracked entity contained', name: 'Tracking containment met' },
2020
]);

x-pack/plugins/stack_alerts/server/alert_types/geo_threshold/tests/alert_type.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('alertType', () => {
1414

1515
it('alert type creation structure is the expected value', async () => {
1616
expect(alertType.id).toBe('.geo-threshold');
17-
expect(alertType.name).toBe('Geo tracking threshold');
17+
expect(alertType.name).toBe('Tracking threshold');
1818
expect(alertType.actionGroups).toEqual([
1919
{ id: 'tracking threshold met', name: 'Tracking threshold met' },
2020
]);

x-pack/plugins/stack_alerts/server/plugin.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ describe('AlertingBuiltins Plugin', () => {
6363
},
6464
],
6565
"id": ".geo-threshold",
66-
"name": "Geo tracking threshold",
66+
"name": "Tracking threshold",
6767
}
6868
`);
6969

x-pack/plugins/translations/translations/ja-JP.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9297,7 +9297,6 @@
92979297
"xpack.infra.logFlyout.setFilterTooltip": "フィルターでイベントを表示",
92989298
"xpack.infra.logFlyout.valueColumnLabel": "値",
92999299
"xpack.infra.logs.alertFlyout.addCondition": "条件を追加",
9300-
"xpack.infra.logs.alertFlyout.alertName": "ログしきい値",
93019300
"xpack.infra.logs.alertFlyout.criterionComparatorValueTitle": "比較:値",
93029301
"xpack.infra.logs.alertFlyout.criterionFieldTitle": "フィールド",
93039302
"xpack.infra.logs.alertFlyout.error.criterionComparatorRequired": "コンパレーターが必要です。",
@@ -9629,7 +9628,6 @@
96299628
"xpack.infra.metrics.alertFlyout.aggregationText.p99": "99パーセンタイル",
96309629
"xpack.infra.metrics.alertFlyout.aggregationText.rate": "レート",
96319630
"xpack.infra.metrics.alertFlyout.aggregationText.sum": "合計",
9632-
"xpack.infra.metrics.alertFlyout.alertName": "メトリックしきい値",
96339631
"xpack.infra.metrics.alertFlyout.alertOnNoData": "データがない場合に通知する",
96349632
"xpack.infra.metrics.alertFlyout.alertPreviewError": "このアラート条件をプレビューするときにエラーが発生しました",
96359633
"xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc": "しばらくたってから再試行するか、詳細を確認してください。",
@@ -9718,7 +9716,6 @@
97189716
"xpack.infra.metrics.expressionItems.components.closablePopoverTitle.closeLabel": "閉じる",
97199717
"xpack.infra.metrics.invalidNodeErrorDescription": "構成をよく確認してください",
97209718
"xpack.infra.metrics.invalidNodeErrorTitle": "{nodeName} がメトリックデータを収集していないようです",
9721-
"xpack.infra.metrics.inventory.alertFlyout.alertName": "インベントリ",
97229719
"xpack.infra.metrics.loadingNodeDataText": "データを読み込み中",
97239720
"xpack.infra.metrics.missingTSVBModelError": "{nodeType}では{metricId}のTSVBモデルが存在しません",
97249721
"xpack.infra.metrics.pluginTitle": "メトリック",
@@ -19137,7 +19134,6 @@
1913719134
"xpack.stackAlerts.geoThreshold.indexLabel": "インデックス",
1913819135
"xpack.stackAlerts.geoThreshold.indexPatternSelectLabel": "インデックスパターン",
1913919136
"xpack.stackAlerts.geoThreshold.indexPatternSelectPlaceholder": "インデックスパターンを選択",
19140-
"xpack.stackAlerts.geoThreshold.name.trackingThreshold": "追跡しきい値",
1914119137
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisLinkTextDescription": "インデックスパターンを作成します",
1914219138
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisPrefixDescription": "次のことが必要です ",
1914319139
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisSuffixDescription": " 地理空間フィールドを含む",
@@ -19512,7 +19508,6 @@
1951219508
"xpack.triggersActionsUI.sections.alertForm.renotifyFieldLabel": "通知間隔",
1951319509
"xpack.triggersActionsUI.sections.alertForm.renotifyWithTooltip": "アラートがアクティブな間にアクションを繰り返す頻度を定義します。",
1951419510
"xpack.triggersActionsUI.sections.alertForm.selectAlertActionTypeTitle": "アクションタイプを選択してください",
19515-
"xpack.triggersActionsUI.sections.alertForm.selectedAlertTypeTitle": "{alertType}",
1951619511
"xpack.triggersActionsUI.sections.alertForm.unableToAddAction": "デフォルトアクショングループの定義がないのでアクションを追加できません",
1951719512
"xpack.triggersActionsUI.sections.alertForm.unableToLoadActionsMessage": "コネクターを読み込めません",
1951819513
"xpack.triggersActionsUI.sections.alertForm.unableToLoadActionTypesMessage": "アクションタイプを読み込めません",

x-pack/plugins/translations/translations/zh-CN.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9306,7 +9306,6 @@
93069306
"xpack.infra.logFlyout.setFilterTooltip": "使用筛选查看事件",
93079307
"xpack.infra.logFlyout.valueColumnLabel": "值",
93089308
"xpack.infra.logs.alertFlyout.addCondition": "添加条件",
9309-
"xpack.infra.logs.alertFlyout.alertName": "日志阈值",
93109309
"xpack.infra.logs.alertFlyout.criterionComparatorValueTitle": "对比:值",
93119310
"xpack.infra.logs.alertFlyout.criterionFieldTitle": "字段",
93129311
"xpack.infra.logs.alertFlyout.error.criterionComparatorRequired": "比较运算符必填。",
@@ -9639,7 +9638,6 @@
96399638
"xpack.infra.metrics.alertFlyout.aggregationText.p99": "第 99 个百分位",
96409639
"xpack.infra.metrics.alertFlyout.aggregationText.rate": "比率",
96419640
"xpack.infra.metrics.alertFlyout.aggregationText.sum": "求和",
9642-
"xpack.infra.metrics.alertFlyout.alertName": "指标阈值",
96439641
"xpack.infra.metrics.alertFlyout.alertOnNoData": "没数据时提醒我",
96449642
"xpack.infra.metrics.alertFlyout.alertPreviewError": "尝试预览此告警条件时发生错误",
96459643
"xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc": "请稍后重试或查看详情了解更多信息。",
@@ -9731,7 +9729,6 @@
97319729
"xpack.infra.metrics.expressionItems.components.closablePopoverTitle.closeLabel": "关闭",
97329730
"xpack.infra.metrics.invalidNodeErrorDescription": "反复检查您的配置",
97339731
"xpack.infra.metrics.invalidNodeErrorTitle": "似乎 {nodeName} 未在收集任何指标数据",
9734-
"xpack.infra.metrics.inventory.alertFlyout.alertName": "库存",
97359732
"xpack.infra.metrics.loadingNodeDataText": "正在加载数据",
97369733
"xpack.infra.metrics.missingTSVBModelError": "{nodeType} 的 {metricId} TSVB 模型不存在",
97379734
"xpack.infra.metrics.pluginTitle": "指标",
@@ -19155,7 +19152,6 @@
1915519152
"xpack.stackAlerts.geoThreshold.indexLabel": "索引",
1915619153
"xpack.stackAlerts.geoThreshold.indexPatternSelectLabel": "索引模式",
1915719154
"xpack.stackAlerts.geoThreshold.indexPatternSelectPlaceholder": "选择索引模式",
19158-
"xpack.stackAlerts.geoThreshold.name.trackingThreshold": "跟踪阈值",
1915919155
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisLinkTextDescription": "创建索引模式",
1916019156
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisPrefixDescription": "您将需要 ",
1916119157
"xpack.stackAlerts.geoThreshold.noIndexPattern.doThisSuffixDescription": " (包含地理空间字段)。",
@@ -19531,7 +19527,6 @@
1953119527
"xpack.triggersActionsUI.sections.alertForm.renotifyFieldLabel": "通知频率",
1953219528
"xpack.triggersActionsUI.sections.alertForm.renotifyWithTooltip": "定义告警处于活动状态时重复操作的频率。",
1953319529
"xpack.triggersActionsUI.sections.alertForm.selectAlertActionTypeTitle": "选择操作类型",
19534-
"xpack.triggersActionsUI.sections.alertForm.selectedAlertTypeTitle": "{alertType}",
1953519530
"xpack.triggersActionsUI.sections.alertForm.unableToAddAction": "无法添加操作,因为未定义默认操作组",
1953619531
"xpack.triggersActionsUI.sections.alertForm.unableToLoadActionsMessage": "无法加载连接器",
1953719532
"xpack.triggersActionsUI.sections.alertForm.unableToLoadActionTypesMessage": "无法加载操作类型",

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ describe('alert_edit', () => {
5252
const alertType = {
5353
id: 'my-alert-type',
5454
iconClass: 'test',
55-
name: 'test-alert',
5655
description: 'test',
5756
documentationUrl: null,
5857
validate: (): ValidationResult => {

0 commit comments

Comments
 (0)