Skip to content

Commit d64dc9c

Browse files
pheyospheyos
committed
Apply changes to transform tests
1 parent ee4f8a5 commit d64dc9c

File tree

6 files changed

+172
-200
lines changed

6 files changed

+172
-200
lines changed

‎x-pack/test/functional/apps/transform/cloning.ts‎

Lines changed: 41 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -87,138 +87,130 @@ export default function ({ getService }: FtrProviderContext) {
8787
await transform.testResources.deleteIndexPatternByTitle(testData.destinationIndex);
8888
});
8989

90-
it('should load the home page', async () => {
90+
it('opens the existing transform in the wizard', async () => {
91+
await transform.testExecution.logTestStep('should load the home page');
9192
await transform.navigation.navigateTo();
9293
await transform.management.assertTransformListPageExists();
93-
});
9494

95-
it('should display the transforms table', async () => {
95+
await transform.testExecution.logTestStep('should display the transforms table');
9696
await transform.management.assertTransformsTableExists();
97-
});
9897

99-
it('should display the original transform in the transform list', async () => {
98+
await transform.testExecution.logTestStep(
99+
'should display the original transform in the transform list'
100+
);
100101
await transform.table.refreshTransformList();
101102
await transform.table.filterWithSearchString(transformConfig.id);
102103
const rows = await transform.table.parseTransformTable();
103104
expect(rows.filter((row) => row.id === transformConfig.id)).to.have.length(1);
104-
});
105105

106-
it('should show the actions popover', async () => {
106+
await transform.testExecution.logTestStep('should show the actions popover');
107107
await transform.table.assertTransformRowActions(false);
108-
});
109108

110-
it('should display the define pivot step', async () => {
109+
await transform.testExecution.logTestStep('should display the define pivot step');
111110
await transform.table.clickTransformRowAction('Clone');
112111
await transform.wizard.assertDefineStepActive();
113112
});
114113

115-
it('should load the index preview', async () => {
114+
it('navigates through the wizard, checks and sets all needed fields', async () => {
115+
await transform.testExecution.logTestStep('should load the index preview');
116116
await transform.wizard.assertIndexPreviewLoaded();
117-
});
118117

119-
it('should show the index preview', async () => {
118+
await transform.testExecution.logTestStep('should show the index preview');
120119
await transform.wizard.assertIndexPreview(
121120
testData.expected.indexPreview.columns,
122121
testData.expected.indexPreview.rows
123122
);
124-
});
125123

126-
it('should display the query input', async () => {
124+
await transform.testExecution.logTestStep('should display the query input');
127125
await transform.wizard.assertQueryInputExists();
128126
await transform.wizard.assertQueryValue('');
129-
});
130127

131-
it('should show the pre-filled group-by configuration', async () => {
128+
await transform.testExecution.logTestStep(
129+
'should show the pre-filled group-by configuration'
130+
);
132131
await transform.wizard.assertGroupByEntryExists(
133132
testData.expected.groupBy.index,
134133
testData.expected.groupBy.label
135134
);
136-
});
137135

138-
it('should show the pre-filled aggs configuration', async () => {
136+
await transform.testExecution.logTestStep(
137+
'should show the pre-filled aggs configuration'
138+
);
139139
await transform.wizard.assertAggregationEntryExists(
140140
testData.expected.aggs.index,
141141
testData.expected.aggs.label
142142
);
143-
});
144143

145-
it('should show the pivot preview', async () => {
144+
await transform.testExecution.logTestStep('should show the pivot preview');
146145
await transform.wizard.assertPivotPreviewChartHistogramButtonMissing();
147146
await transform.wizard.assertPivotPreviewColumnValues(
148147
testData.expected.pivotPreview.column,
149148
testData.expected.pivotPreview.values
150149
);
151-
});
152150

153-
it('should load the details step', async () => {
151+
await transform.testExecution.logTestStep('should load the details step');
154152
await transform.wizard.advanceToDetailsStep();
155-
});
156153

157-
it('should input the transform id', async () => {
154+
await transform.testExecution.logTestStep('should input the transform id');
158155
await transform.wizard.assertTransformIdInputExists();
159156
await transform.wizard.assertTransformIdValue('');
160157
await transform.wizard.setTransformId(testData.transformId);
161-
});
162158

163-
it('should input the transform description', async () => {
159+
await transform.testExecution.logTestStep('should input the transform description');
164160
await transform.wizard.assertTransformDescriptionInputExists();
165161
await transform.wizard.assertTransformDescriptionValue('');
166162
await transform.wizard.setTransformDescription(testData.transformDescription);
167-
});
168163

169-
it('should input the destination index', async () => {
164+
await transform.testExecution.logTestStep('should input the destination index');
170165
await transform.wizard.assertDestinationIndexInputExists();
171166
await transform.wizard.assertDestinationIndexValue('');
172167
await transform.wizard.setDestinationIndex(testData.destinationIndex);
173-
});
174168

175-
it('should display the create index pattern switch', async () => {
169+
await transform.testExecution.logTestStep(
170+
'should display the create index pattern switch'
171+
);
176172
await transform.wizard.assertCreateIndexPatternSwitchExists();
177173
await transform.wizard.assertCreateIndexPatternSwitchCheckState(true);
178-
});
179174

180-
it('should display the continuous mode switch', async () => {
175+
await transform.testExecution.logTestStep('should display the continuous mode switch');
181176
await transform.wizard.assertContinuousModeSwitchExists();
182177
await transform.wizard.assertContinuousModeSwitchCheckState(false);
183-
});
184178

185-
it('should load the create step', async () => {
179+
await transform.testExecution.logTestStep('should load the create step');
186180
await transform.wizard.advanceToCreateStep();
187-
});
188181

189-
it('should display the create and start button', async () => {
182+
await transform.testExecution.logTestStep('should display the create and start button');
190183
await transform.wizard.assertCreateAndStartButtonExists();
191184
await transform.wizard.assertCreateAndStartButtonEnabled(true);
192-
});
193185

194-
it('should display the create button', async () => {
186+
await transform.testExecution.logTestStep('should display the create button');
195187
await transform.wizard.assertCreateButtonExists();
196188
await transform.wizard.assertCreateButtonEnabled(true);
197-
});
198189

199-
it('should display the copy to clipboard button', async () => {
190+
await transform.testExecution.logTestStep('should display the copy to clipboard button');
200191
await transform.wizard.assertCopyToClipboardButtonExists();
201192
await transform.wizard.assertCopyToClipboardButtonEnabled(true);
202193
});
203194

204-
it('should create the transform', async () => {
195+
it('runs the clone transform and displays it correctly in the job list', async () => {
196+
await transform.testExecution.logTestStep('should create the transform');
205197
await transform.wizard.createTransform();
206-
});
207198

208-
it('should start the transform and finish processing', async () => {
199+
await transform.testExecution.logTestStep(
200+
'should start the transform and finish processing'
201+
);
209202
await transform.wizard.startTransform();
210203
await transform.wizard.waitForProgressBarComplete();
211-
});
212204

213-
it('should return to the management page', async () => {
205+
await transform.testExecution.logTestStep('should return to the management page');
214206
await transform.wizard.returnToManagement();
215-
});
216207

217-
it('should display the transforms table', async () => {
208+
await transform.testExecution.logTestStep('should display the transforms table');
218209
await transform.management.assertTransformsTableExists();
219-
});
220210

221-
it('should display the created transform in the transform list', async () => {
211+
await transform.testExecution.logTestStep(
212+
'should display the created transform in the transform list'
213+
);
222214
await transform.table.refreshTransformList();
223215
await transform.table.filterWithSearchString(testData.transformId);
224216
const rows = await transform.table.parseTransformTable();

‎x-pack/test/functional/apps/transform/creation_index_pattern.ts‎

Lines changed: 41 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -260,63 +260,54 @@ export default function ({ getService }: FtrProviderContext) {
260260
await transform.testResources.deleteIndexPatternByTitle(testData.destinationIndex);
261261
});
262262

263-
it('loads the home page', async () => {
263+
it('loads the wizard for the source data', async () => {
264+
await transform.testExecution.logTestStep('loads the home page');
264265
await transform.navigation.navigateTo();
265266
await transform.management.assertTransformListPageExists();
266-
});
267267

268-
it('displays the stats bar', async () => {
268+
await transform.testExecution.logTestStep('displays the stats bar');
269269
await transform.management.assertTransformStatsBarExists();
270-
});
271270

272-
it('loads the source selection modal', async () => {
271+
await transform.testExecution.logTestStep('loads the source selection modal');
273272
await transform.management.startTransformCreation();
274-
});
275273

276-
it('selects the source data', async () => {
274+
await transform.testExecution.logTestStep('selects the source data');
277275
await transform.sourceSelection.selectSource(testData.source);
278276
});
279277

280-
it('displays the define pivot step', async () => {
278+
it('navigates through the wizard and sets all needed fields', async () => {
279+
await transform.testExecution.logTestStep('displays the define pivot step');
281280
await transform.wizard.assertDefineStepActive();
282-
});
283281

284-
it('loads the index preview', async () => {
282+
await transform.testExecution.logTestStep('loads the index preview');
285283
await transform.wizard.assertIndexPreviewLoaded();
286-
});
287284

288-
it('shows the index preview', async () => {
285+
await transform.testExecution.logTestStep('shows the index preview');
289286
await transform.wizard.assertIndexPreview(
290287
testData.expected.indexPreview.columns,
291288
testData.expected.indexPreview.rows
292289
);
293-
});
294290

295-
it('displays an empty pivot preview', async () => {
291+
await transform.testExecution.logTestStep('displays an empty pivot preview');
296292
await transform.wizard.assertPivotPreviewEmpty();
297-
});
298293

299-
it('displays the query input', async () => {
294+
await transform.testExecution.logTestStep('displays the query input');
300295
await transform.wizard.assertQueryInputExists();
301296
await transform.wizard.assertQueryValue('');
302-
});
303297

304-
it('displays the advanced query editor switch', async () => {
298+
await transform.testExecution.logTestStep('displays the advanced query editor switch');
305299
await transform.wizard.assertAdvancedQueryEditorSwitchExists();
306300
await transform.wizard.assertAdvancedQueryEditorSwitchCheckState(false);
307-
});
308301

309-
it('enables the index preview histogram charts', async () => {
302+
await transform.testExecution.logTestStep('enables the index preview histogram charts');
310303
await transform.wizard.enableIndexPreviewHistogramCharts();
311-
});
312304

313-
it('displays the index preview histogram charts', async () => {
305+
await transform.testExecution.logTestStep('displays the index preview histogram charts');
314306
await transform.wizard.assertIndexPreviewHistogramCharts(
315307
testData.expected.histogramCharts
316308
);
317-
});
318309

319-
it('adds the group by entries', async () => {
310+
await transform.testExecution.logTestStep('adds the group by entries');
320311
for (const [index, entry] of testData.groupByEntries.entries()) {
321312
await transform.wizard.assertGroupByInputExists();
322313
await transform.wizard.assertGroupByInputValue([]);
@@ -327,112 +318,97 @@ export default function ({ getService }: FtrProviderContext) {
327318
entry.intervalLabel
328319
);
329320
}
330-
});
331321

332-
it('adds the aggregation entries', async () => {
322+
await transform.testExecution.logTestStep('adds the aggregation entries');
333323
await transform.wizard.addAggregationEntries(testData.aggregationEntries);
334-
});
335324

336-
it('displays the advanced pivot editor switch', async () => {
325+
await transform.testExecution.logTestStep('displays the advanced pivot editor switch');
337326
await transform.wizard.assertAdvancedPivotEditorSwitchExists();
338327
await transform.wizard.assertAdvancedPivotEditorSwitchCheckState(false);
339-
});
340328

341-
it('displays the advanced configuration', async () => {
329+
await transform.testExecution.logTestStep('displays the advanced configuration');
342330
await transform.wizard.enabledAdvancedPivotEditor();
343331
await transform.wizard.assertAdvancedPivotEditorContent(
344332
testData.expected.pivotAdvancedEditorValueArr
345333
);
346-
});
347334

348-
it('loads the pivot preview', async () => {
335+
await transform.testExecution.logTestStep('loads the pivot preview');
349336
await transform.wizard.assertPivotPreviewLoaded();
350-
});
351337

352-
it('shows the pivot preview', async () => {
338+
await transform.testExecution.logTestStep('shows the pivot preview');
353339
await transform.wizard.assertPivotPreviewChartHistogramButtonMissing();
354340
await transform.wizard.assertPivotPreviewColumnValues(
355341
testData.expected.pivotPreview.column,
356342
testData.expected.pivotPreview.values
357343
);
358-
});
359344

360-
it('loads the details step', async () => {
345+
await transform.testExecution.logTestStep('loads the details step');
361346
await transform.wizard.advanceToDetailsStep();
362-
});
363347

364-
it('inputs the transform id', async () => {
348+
await transform.testExecution.logTestStep('inputs the transform id');
365349
await transform.wizard.assertTransformIdInputExists();
366350
await transform.wizard.assertTransformIdValue('');
367351
await transform.wizard.setTransformId(testData.transformId);
368-
});
369352

370-
it('inputs the transform description', async () => {
353+
await transform.testExecution.logTestStep('inputs the transform description');
371354
await transform.wizard.assertTransformDescriptionInputExists();
372355
await transform.wizard.assertTransformDescriptionValue('');
373356
await transform.wizard.setTransformDescription(testData.transformDescription);
374-
});
375357

376-
it('inputs the destination index', async () => {
358+
await transform.testExecution.logTestStep('inputs the destination index');
377359
await transform.wizard.assertDestinationIndexInputExists();
378360
await transform.wizard.assertDestinationIndexValue('');
379361
await transform.wizard.setDestinationIndex(testData.destinationIndex);
380-
});
381362

382-
it('displays the create index pattern switch', async () => {
363+
await transform.testExecution.logTestStep('displays the create index pattern switch');
383364
await transform.wizard.assertCreateIndexPatternSwitchExists();
384365
await transform.wizard.assertCreateIndexPatternSwitchCheckState(true);
385-
});
386366

387-
it('displays the continuous mode switch', async () => {
367+
await transform.testExecution.logTestStep('displays the continuous mode switch');
388368
await transform.wizard.assertContinuousModeSwitchExists();
389369
await transform.wizard.assertContinuousModeSwitchCheckState(false);
390-
});
391370

392-
it('loads the create step', async () => {
371+
await transform.testExecution.logTestStep('loads the create step');
393372
await transform.wizard.advanceToCreateStep();
394-
});
395373

396-
it('displays the create and start button', async () => {
374+
await transform.testExecution.logTestStep('displays the create and start button');
397375
await transform.wizard.assertCreateAndStartButtonExists();
398376
await transform.wizard.assertCreateAndStartButtonEnabled(true);
399-
});
400377

401-
it('displays the create button', async () => {
378+
await transform.testExecution.logTestStep('displays the create button');
402379
await transform.wizard.assertCreateButtonExists();
403380
await transform.wizard.assertCreateButtonEnabled(true);
404-
});
405381

406-
it('displays the copy to clipboard button', async () => {
382+
await transform.testExecution.logTestStep('displays the copy to clipboard button');
407383
await transform.wizard.assertCopyToClipboardButtonExists();
408384
await transform.wizard.assertCopyToClipboardButtonEnabled(true);
409385
});
410386

411-
it('creates the transform', async () => {
387+
it('runs the transform and displays it correctly in the job list', async () => {
388+
await transform.testExecution.logTestStep('creates the transform');
412389
await transform.wizard.createTransform();
413-
});
414390

415-
it('starts the transform and finishes processing', async () => {
391+
await transform.testExecution.logTestStep('starts the transform and finishes processing');
416392
await transform.wizard.startTransform();
417393
await transform.wizard.waitForProgressBarComplete();
418-
});
419394

420-
it('returns to the management page', async () => {
395+
await transform.testExecution.logTestStep('returns to the management page');
421396
await transform.wizard.returnToManagement();
422-
});
423397

424-
it('displays the transforms table', async () => {
398+
await transform.testExecution.logTestStep('displays the transforms table');
425399
await transform.management.assertTransformsTableExists();
426-
});
427400

428-
it('displays the created transform in the transform list', async () => {
401+
await transform.testExecution.logTestStep(
402+
'displays the created transform in the transform list'
403+
);
429404
await transform.table.refreshTransformList();
430405
await transform.table.filterWithSearchString(testData.transformId);
431406
const rows = await transform.table.parseTransformTable();
432407
expect(rows.filter((row) => row.id === testData.transformId)).to.have.length(1);
433-
});
434408

435-
it('transform creation displays details for the created transform in the transform list', async () => {
409+
await transform.testExecution.logTestStep(
410+
'transform creation displays details for the created transform in the transform list'
411+
);
436412
await transform.table.assertTransformRowFields(testData.transformId, {
437413
id: testData.transformId,
438414
description: testData.transformDescription,

0 commit comments

Comments
 (0)