remove unecessary url from hooks

Author: parkiino

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/host_details.tsx

@@ -46,11 +46,9 @@ const LinkToExternalApp = styled(LinkToApp)`
 `;
 
 export const HostDetails = memo(({ details }: { details: HostMetadata }) => {
-  const { appId: logsAppId, appPath: logsAppPath, url: logsUrl } = useHostLogsUrl(details.host.id);
+  const { appId: logsAppId, appPath: logsAppPath } = useHostLogsUrl(details.host.id);
   const endpointVersion = useHostSelector(latestEndpointVersion);
-  const { appId: ingestAppId, appPath: ingestAppPath, url: ingestUrl } = useHostIngestUrl(
-    endpointVersion
-  );
+  const { appId: ingestAppId, appPath: ingestAppPath } = useHostIngestUrl(endpointVersion);
   const queryParams = useHostSelector(uiQueryParams);
   const policyStatus = useHostSelector(
     policyResponseStatus
@@ -179,7 +177,6 @@ export const HostDetails = memo(({ details }: { details: HostMetadata }) => {
           className="hostDetailsLinkToIngest"
           appId={ingestAppId}
           appPath={ingestAppPath}
-          href={ingestUrl}
           data-test-subj="hostDetailsLinkToIngest"
         >
           <EuiIcon type="savedObjectsApp" className="linkToAppIcon" />
@@ -201,7 +198,6 @@ export const HostDetails = memo(({ details }: { details: HostMetadata }) => {
         <LinkToExternalApp
           appId={logsAppId}
           appPath={logsAppPath}
-          href={logsUrl}
           data-test-subj="hostDetailsLinkToLogs"
         >
           <EuiIcon type="logsApp" className="linkToAppIcon" />

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/hooks.ts

@@ -11,7 +11,6 @@ import {
   MANAGEMENT_STORE_ENDPOINTS_NAMESPACE,
   MANAGEMENT_STORE_GLOBAL_NAMESPACE,
 } from '../../../common/constants';
-import { useKibana } from '../../../../common/lib/kibana';
 import { State } from '../../../../common/store';
 
 export function useHostSelector<TSelected>(selector: (state: HostState) => TSelected) {
@@ -26,34 +25,30 @@ export function useHostSelector<TSelected>(selector: (state: HostState) => TSele
  * Returns an object that contains Kibana Logs app and URL information for a given host id
  * @param hostId
  */
-export const useHostLogsUrl = (hostId: string): { url: string; appId: string; appPath: string } => {
-  const { services } = useKibana();
+export const useHostLogsUrl = (hostId: string): { appId: string; appPath: string } => {
   return useMemo(() => {
     const appPath = `/stream?logFilter=(expression:'host.id:${hostId}',kind:kuery)`;
     return {
-      url: `${services.application.getUrlForApp('logs')}${appPath}`,
       appId: 'logs',
       appPath,
     };
-  }, [hostId, services.application]);
+  }, [hostId]);
 };
 
 /**
  * Returns an object that contains Ingest app and URL information
  */
 export const useHostIngestUrl = (
   latestEndpointVersion: string | undefined
-): { url: string; appId: string; appPath: string } => {
-  const { services } = useKibana();
+): { appId: string; appPath: string } => {
   return useMemo(() => {
     let appPath = `#/integrations`;
     if (latestEndpointVersion !== undefined) {
       appPath = `#/integrations/endpoint-${latestEndpointVersion}/add-datasource`;
     }
     return {
-      url: `${services.application.getUrlForApp('ingestManager')}${appPath}`,
       appId: 'ingestManager',
       appPath,
     };
-  }, [latestEndpointVersion, services.application]);
+  }, [latestEndpointVersion]);
 };